Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190508174356.13952-1-borneo.antonio@gmail.com> <AT5PR8401MB1169149078CDB1274A259703AB320@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM>
In-Reply-To: <AT5PR8401MB1169149078CDB1274A259703AB320@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM>
From:   Antonio Borneo <borneo.antonio@gmail.com>
Date:   Thu, 9 May 2019 00:03:32 +0200
Message-ID: <CAAj6DX0CQtB8y71bc-X36i4V36R5WjJ2199JiR4+717T1sDNqA@mail.gmail.com>
Subject: Re: [PATCH v2] checkpatch: add command-line option for TAB size
To:     "Elliott, Robert (Servers)" <elliott@hpe.com>
Cc:     Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 8, 2019 at 11:14 PM Elliott, Robert (Servers)
<elliott@hpe.com> wrote:
...
> Checking for 0 before using the value in division and modulo
> operations would be prudent.

True!
From command line, $tabsize is parsed as integer so I should sort out
any non-positive value.
Will add a check after GetOptions(...)
die "Invalid TAB size: $tabsize\n" if ($tabsize <= 0);