Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp131613yba; Wed, 8 May 2019 17:47:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxy+MmomKYaAGP+Ua1h1GCaUpMIuSxUXn5zBHMvLl26lwxlDTj52FMtt9NvDo9ZZmfIddML X-Received: by 2002:a17:902:f302:: with SMTP id gb2mr1145303plb.162.1557362841693; Wed, 08 May 2019 17:47:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557362841; cv=none; d=google.com; s=arc-20160816; b=pT5CIq+8x0fnIDm5wFz+uX/T/e32xkEMxrGmwIXpop0GOnisoJm6t5LxfXWJqOkrHR 1CAlFveXW5nIUL46IgdZ2ZUMDoHS0k53fF3wXFRMtCSYXeO/Jw9D1hbsYubg3022ByaO tWS5u+Lq3C+QivU3k8mmuLR15HTCa099C+XtSpWQ/O8MzK1jeSFACl5v5H33yYiu990s MvTDfBI4fVyt7NxvJo6L0uoJ+UNHCxHl5AFWwhFaEPXDawKmftDJi8BJ7YbH3fFZFPe3 vyAeGUrkBQWwNy31Hne62I6toixmNYGpz52y7rqVAltjmRaoCXMfFEXDFKP9lGaIMw7p kEvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature:dkim-filter; bh=0MJ5gBk9NRKE+Xi+tjUDFK3eCRm84EkfBQ9ymup5aDQ=; b=FR8cQTMFyFkCVDYidWOsvr5CkyT/5Hygm/sqjmqifmlZXJpLcC6tQZrKq1QT8ydT33 e0ys8pi2FRiKTEPs5SF/HxdS1go8CZCIM3TtJXclCr+xV/1FKSjH/pb3M3vwcb5SMBd8 NnSzhXat48tm2xf6/8uBn4LE37nxOC3JAZj9d1Xm+XIlIbGfL7ALQkTfSSyUhWYM7pkZ qcEy4CAjkxE+nADgcWMpVJaO46p3YfnfwUFTgF4yrGGCm4HFtwMW+FmtHG4+7GfwuyuO REFgHUZVV5ekXxseICVYiNdFyoDYGqJ/nB0wi3lYO9yI86t4oaKnl64FFCxSDn2nxNuQ +p+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JCmHD6FJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11si711383pge.187.2019.05.08.17.46.50; Wed, 08 May 2019 17:47:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JCmHD6FJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbfEIApO (ORCPT + 99 others); Wed, 8 May 2019 20:45:14 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:46571 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbfEIApN (ORCPT ); Wed, 8 May 2019 20:45:13 -0400 Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) (authenticated) by conssluserg-01.nifty.com with ESMTP id x490infd010328; Thu, 9 May 2019 09:44:50 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com x490infd010328 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557362690; bh=0MJ5gBk9NRKE+Xi+tjUDFK3eCRm84EkfBQ9ymup5aDQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JCmHD6FJ7iNgcYdHMB5zTIsTAP7bIjGlPPobtg1f2Q2FvhijqnOCXbOKna11KNeLQ WpMTsaOPSZQnUp5eopUmN8nRhBrSrw33r962kOmH/U5zm0+XCV34Nhj+vLd+iv7LWT 0JS/gINTKHMBvZidFga5kouW0LBDrL9RaXG/IoGcBqrpVkV4yHqEuvApEwMTleFyk6 5YDjjRh1aJ24jAOx9F8OWGS5s+dZUQe8O5ByYECWS6tvFRKln/LLLllRSIRDZikxPY 7EC42+AlUaP+1POXNcl0TkcJq0Pwi2cJLTGk38Y7oyxttEHvA04tEwt0iV3eTabLE1 L8yZFxsPVC81w== X-Nifty-SrcIP: [209.85.217.52] Received: by mail-vs1-f52.google.com with SMTP id w13so318678vsc.4; Wed, 08 May 2019 17:44:50 -0700 (PDT) X-Gm-Message-State: APjAAAWQnED/cgLloX4Wl10OdtYnTF/J24QxRMdZIG6xke6EBMbHdKrS nMTqnLH5bQzITOborouoMopiYaD/teW1pNTRHOU= X-Received: by 2002:a67:fc4:: with SMTP id 187mr702130vsp.215.1557362689436; Wed, 08 May 2019 17:44:49 -0700 (PDT) MIME-Version: 1.0 References: <20190424180223.253025-1-ndesaulniers@google.com> In-Reply-To: From: Masahiro Yamada Date: Thu, 9 May 2019 09:44:13 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption To: Nick Desaulniers Cc: Yoshinori Sato , Rich Felker , Geert Uytterhoeven , Andy Lutomirski , clang-built-linux , Linux-sh list , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 9, 2019 at 5:13 AM Nick Desaulniers wrote: > > bumping for review, as the merge window is now open. sh is not very active these days. I applied this to my kbuild tree. I will send PR for this in the current MW. Thanks. > On Tue, Apr 30, 2019 at 1:26 PM Nick Desaulniers > wrote: > > > > On Wed, Apr 24, 2019 at 11:02 AM Nick Desaulniers > > wrote: > > > > > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > > > of binutils for the kernel according to > > > Documentation/process/changes.rst is 2.20. > > > > > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > > > Cc: clang-built-linux@googlegroups.com > > > Suggested-by: Masahiro Yamada > > > Signed-off-by: Nick Desaulniers > > > --- > > > Changes V1 -> V2: > > > * update commit subject and message as per Masahiro/Geert. > > > > > > To Geert's question about minimum binutils versions; no change needed to > > > binutils. > > > > > > > > > arch/sh/kernel/vsyscall/Makefile | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile > > > index 5db6579bc44c..6e8664448048 100644 > > > --- a/arch/sh/kernel/vsyscall/Makefile > > > +++ b/arch/sh/kernel/vsyscall/Makefile > > > @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@ > > > > > > export CPPFLAGS_vsyscall.lds += -P -C -Ush > > > > > > -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \ > > > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > > > +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv > > > > > > SYSCFLAGS_vsyscall-trapa.so = $(vsyscall-flags) > > > > > > -- > > > 2.21.0.593.g511ec345e18-goog > > > > > > > bumping for review > > -- > > Thanks, > > ~Nick Desaulniers > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada