From: Keith Owens <kaos@sgi.com>
To: "Jan Beulich" <JBeulich@novell.com>
cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/39] NLKD - kernel trace buffer access 
In-reply-to: Your message of "Wed, 09 Nov 2005 15:09:13 BST."
             <43721119.76F0.0078.0@novell.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 10 Nov 2005 16:44:52 +1100
Message-ID: <7640.1131601492@kao2.melbourne.sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1297
Lines: 32

On Wed, 09 Nov 2005 15:09:13 +0100, 
"Jan Beulich" <JBeulich@novell.com> wrote:
>Debug extension implementation for NLKD to access the kernel trace
>buffer.

 printk.c |  187 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 187 insertions(+)

This is complete overkill in printk.c.  The only change required to
printk is to add a routine which gets the parameters that define the
buffer, see below from KDB.  The rest of the code in your patch belongs
in the debugger, not in printk.

#ifdef	CONFIG_KDB
/* kdb dmesg command needs access to the syslog buffer.  do_syslog() uses locks
 * so it cannot be used during debugging.  Just tell kdb where the start and
 * end of the physical and logical logs are.  This is equivalent to do_syslog(3).
 */
void kdb_syslog_data(char *syslog_data[4])
{
	syslog_data[0] = log_buf;
	syslog_data[1] = log_buf + log_buf_len;
	syslog_data[2] = log_buf + log_end - (logged_chars < log_buf_len ? logged_chars : log_buf_len);
	syslog_data[3] = log_buf + log_end;
}
#endif	/* CONFIG_KDB */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/