Date: Thu, 10 Nov 2005 08:47:39 +0100
From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk: cfq forced dispatching fix
Message-ID: <20051110074738.GR3699@suse.de>
References: <20051109171758.GC24115@htj.dyndns.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051109171758.GC24115@htj.dyndns.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 814
Lines: 24

On Thu, Nov 10 2005, Tejun Heo wrote:
> cfq forced dispatching might not return all requests on the queue.
> This bug can hang elevator switchinig and corrupt request ordering
> during flush sequence.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> ---
> 
> Jens, I implemented a separate code path for forced dispatching as it
> seemed too complex/error-prone to handle forced case in normal
> dispatch path.  How do you like this approach?

I like this approach better then mixing the 'force' into various logic
around the function. So applied.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/