Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     Andrew Lunn <andrew@lunn.ch>, Jose Abreu <Jose.Abreu@synopsys.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
Subject: RE: [PATCH net-next 10/11] net: stmmac: Introduce selftests support
Thread-Topic: [PATCH net-next 10/11] net: stmmac: Introduce selftests support
Thread-Index: AQHVBXLbzVq8jQ4wOEqKi4j/REzHDqZh7/UAgACEXjA=
Date:   Thu, 9 May 2019 08:25:14 +0000
Message-ID: <78EB27739596EE489E55E81C33FEC33A0B47AB21@DE02WEMBXB.internal.synopsys.com>
References: <cover.1557300602.git.joabreu@synopsys.com>
 <be9099bbf8783b210dc9034a8b82219984f03250.1557300602.git.joabreu@synopsys.com>
 <20190509022330.GA23758@lunn.ch>
In-Reply-To: <20190509022330.GA23758@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, May 09, 2019 at 03:23:30

> > +static int stmmac_test_eee(struct stmmac_priv *priv)
> > +{
> > +	struct stmmac_extra_stats *initial, *final;
> > +	int timeout =3D 100;
> > +	int ret;
> > +
> > +	ret =3D stmmac_test_loopback(priv);
> > +	if (ret)
> > +		goto out_free_final;
> > +
> > +	/* We have no traffic in the line so, sooner or later it will go LPI =
*/
> > +	while (--timeout) {
> > +		memcpy(final, &priv->xstats, sizeof(*final));
> > +
> > +		if (final->irq_tx_path_in_lpi_mode_n >
> > +		    initial->irq_tx_path_in_lpi_mode_n)
> > +			break;
> > +		msleep(100);
> > +	}
> > +
> > +	if (!timeout) {
> > +		ret =3D -ETIMEDOUT;
> > +		goto out_free_final;
> > +	}
>=20
> Retries would be a better name than timeout.

Ok.

>=20
> Also, 100 * 100 ms seems like a long time.

Ah, yeah. I will adjust to 0.5 or maybe 1 sec max.

>=20
> > +static int stmmac_filter_check(struct stmmac_priv *priv)
> > +{
> > +	if (!(priv->dev->flags & IFF_PROMISC))
> > +		return 0;
> > +
> > +	netdev_warn(priv->dev, "Test can't be run in promiscuous mode!\n");
> > +	return 1;
>=20
> Maybe return EOPNOTSUPP here,

Ok.

>=20
> > +}
> > +
> > +static int stmmac_test_hfilt(struct stmmac_priv *priv)
> > +{
> > +	unsigned char gd_addr[ETH_ALEN] =3D {0x01, 0x0c, 0xcd, 0x04, 0x00, 0x=
00};
> > +	unsigned char bd_addr[ETH_ALEN] =3D {0x06, 0x07, 0x08, 0x09, 0x0a, 0x=
0b};
>=20
> What does gd and bd mean?

Good and Bad :D

>=20
> > +	struct stmmac_packet_attrs attr =3D { };
> > +	int ret;
> > +
> > +	if (stmmac_filter_check(priv))
> > +		return -EOPNOTSUPP;
>=20
> and just return the error code from the call.
>=20
> > +
> > +	ret =3D dev_mc_add(priv->dev, gd_addr);
> > +	if (ret)
> > +		return ret;
> > +
> > +	attr.dst =3D gd_addr;
> > +
> > +	/* Shall receive packet */
> > +	ret =3D __stmmac_test_loopback(priv, &attr);
> > +	if (ret)
> > +		goto cleanup;
> > +
> > +	attr.dst =3D bd_addr;
> > +
> > +	/* Shall NOT receive packet */
> > +	ret =3D __stmmac_test_loopback(priv, &attr);
> > +	ret =3D !ret;
>=20
> What is this test testing? gd is a multicast, where as bd is not.  I
> expect the hardware treats multicast different to unicast. So it would
> make more sense to test two different multicast addresses, one which
> has been added via dev_mc_addr, and one that has not?

Hmm, yeah makes sense. I will adjust.

>=20
> > +
> > +cleanup:
> > +	dev_mc_del(priv->dev, gd_addr);
> > +	return ret;
> > +}
> > +
> > +static int stmmac_test_pfilt(struct stmmac_priv *priv)
> > +{
> > +	unsigned char gd_addr[ETH_ALEN] =3D {0x01, 0x02, 0x03, 0x04, 0x05, 0x=
06};
> > +	unsigned char bd_addr[ETH_ALEN] =3D {0x06, 0x07, 0x08, 0x09, 0x0a, 0x=
0b};
> > +	struct stmmac_packet_attrs attr =3D { };
> > +	int ret;
> > +
> > +	if (stmmac_filter_check(priv))
> > +		return -EOPNOTSUPP;
> > +
> > +	ret =3D dev_uc_add(priv->dev, gd_addr);
> > +	if (ret)
> > +		return ret;
> > +
> > +	attr.dst =3D gd_addr;
> > +
> > +	/* Shall receive packet */
> > +	ret =3D __stmmac_test_loopback(priv, &attr);
> > +	if (ret)
> > +		goto cleanup;
>=20
> gb is a multicast address. Does dev_uc_add() return an error? If it
> does not we should not expect it to actually work, since a multicast
> address should not match a unicast address?

It doesn't return an error and it does calls the set_filter callback in=20
netdev. I will adjust to use unicast address.

> You also seem to be missing a test for adding a unicast address via
> dev_uc_add() and receiving packets for that address, but not receiving
> multicast packets.

Hmm, what if interface was already configured to receive Multicast before=20
running the tests ?

>=20
> > +static const struct stmmac_test {
> > +	char name[ETH_GSTRING_LEN];
> > +	int lb;
> > +	int (*fn)(struct stmmac_priv *priv);
> > +} stmmac_selftests[] =3D {
> > +	{
> > +		.name =3D "MAC Loopback         ",
> > +		.lb =3D STMMAC_LOOPBACK_MAC,
> > +		.fn =3D stmmac_test_loopback,
>=20
> stmmac_test_mac_loopback might be a better name.

Ok.

Thanks for the review!

Thanks,
Jose Miguel Abreu