Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Evan Green <evgreen@chromium.org>, Jens Axboe <axboe@kernel.dk>,
        Martin K Petersen <martin.petersen@oracle.com>
CC:     Bart Van Assche <bvanassche@acm.org>,
        Gwendal Grignou <gwendal@chromium.org>,
        Alexis Savery <asavery@chromium.org>,
        Ming Lei <ming.lei@redhat.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] loop: Report EOPNOTSUPP properly
Thread-Topic: [PATCH v5 1/2] loop: Report EOPNOTSUPP properly
Thread-Index: AQHVBDnP+NEOiOrWR0eHzVHg4XqcIQ==
Date:   Thu, 9 May 2019 16:13:53 +0000
Message-ID: <SN6PR04MB4527AEB53F1CDF938B2E686C86330@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <20190506182736.21064-1-evgreen@chromium.org>
 <20190506182736.21064-2-evgreen@chromium.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6adc0b94-eb81-4e9c-48ec-08d6d499549c
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2019 16:13:53.2726
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB5054
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good to me.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
On 05/06/2019 11:30 AM, Evan Green wrote:=0A=
> Properly plumb out EOPNOTSUPP from loop driver operations, which may=0A=
> get returned when for instance a discard operation is attempted but not=
=0A=
> supported by the underlying block device. Before this change, everything=
=0A=
> was reported in the log as an I/O error, which is scary and not=0A=
> helpful in debugging.=0A=
>=0A=
> Signed-off-by: Evan Green <evgreen@chromium.org>=0A=
> Reviewed-by: Ming Lei <ming.lei@redhat.com>=0A=
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>=0A=
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>=0A=
> ---=0A=
>=0A=
> Changes in v5: None=0A=
> Changes in v4: None=0A=
> Changes in v3:=0A=
> - Updated tags=0A=
>=0A=
> Changes in v2:=0A=
> - Unnested error if statement (Bart)=0A=
>=0A=
>   drivers/block/loop.c | 9 +++++++--=0A=
>   1 file changed, 7 insertions(+), 2 deletions(-)=0A=
>=0A=
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c=0A=
> index bf1c61cab8eb..bbf21ebeccd3 100644=0A=
> --- a/drivers/block/loop.c=0A=
> +++ b/drivers/block/loop.c=0A=
> @@ -458,7 +458,9 @@ static void lo_complete_rq(struct request *rq)=0A=
>=0A=
>   	if (!cmd->use_aio || cmd->ret < 0 || cmd->ret =3D=3D blk_rq_bytes(rq) =
||=0A=
>   	    req_op(rq) !=3D REQ_OP_READ) {=0A=
> -		if (cmd->ret < 0)=0A=
> +		if (cmd->ret =3D=3D -EOPNOTSUPP)=0A=
> +			ret =3D BLK_STS_NOTSUPP;=0A=
> +		else if (cmd->ret < 0)=0A=
>   			ret =3D BLK_STS_IOERR;=0A=
>   		goto end_io;=0A=
>   	}=0A=
> @@ -1892,7 +1894,10 @@ static void loop_handle_cmd(struct loop_cmd *cmd)=
=0A=
>    failed:=0A=
>   	/* complete non-aio request */=0A=
>   	if (!cmd->use_aio || ret) {=0A=
> -		cmd->ret =3D ret ? -EIO : 0;=0A=
> +		if (ret =3D=3D -EOPNOTSUPP)=0A=
> +			cmd->ret =3D ret;=0A=
> +		else=0A=
> +			cmd->ret =3D ret ? -EIO : 0;=0A=
>   		blk_mq_complete_request(rq);=0A=
>   	}=0A=
>   }=0A=
>=0A=
=0A=