Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1018055yba; Thu, 9 May 2019 09:23:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwO5OATSUaoGzbCLOQul8zZrGYwoCN5/8UVNm9Nbhfl7uvXv3+G/IPCvSHjHX3P0ReSxzdA X-Received: by 2002:a17:902:5c6:: with SMTP id f64mr6445812plf.208.1557419030366; Thu, 09 May 2019 09:23:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557419030; cv=none; d=google.com; s=arc-20160816; b=KmBwblIT3Lj8qwIrevo/a/PVFtduOVKrcHfzbqt238TUCwEFwmWfuDJeYwCIy7Yy1l 9t7jk/eObPSerO7BZCUcgirl4RZ4vrPnOVZLLWttHKw4QqlOgYl5MnPBB/KARVjisEI8 VYQs1jvwFyO6cG+zH5Ze69PP1iroQIFdZOLZmeN9ua02LO2DjlhDMyI3X9wDf+8rX2Bg bIQZknuxxdPKkyMtyIGgnDlMhnug/p+XyTNdsZAGSq3TAzLZ7ru/dlzKgjnl55Fei9IT 6FaZ6CTPEG53iGRzX12iMvQVDh8R6FT1iP2A2+QYWveGSYmvC83OoaBz9sXuF6QVpYEs rZzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=b1nzMm6fqxw1iIsfhoX3uBSGb3dbgliFMv7O+7q9O14=; b=nzHhQEvvWio/7QftFyUIwlasGQM8vg7B7SfCTxPPHAFr5lloI94cFtcyygq0TEIdb0 QqRpl/8X314pamRJDkm5s0X2O3vr1FNToEf6fS6WWng5aEVs48KS3+8j6C6oI8GLNlFz rdn7T2jT42DjZgKsA1DjYonNy5wyWU+TYv9EIiDiHj/2q8P/Vk+xRC/Hg9lmG8F564fK UPbo9O8iTNalLybjqJxAT8VyPjiiXd5VqhBmC3LkAucrp3LX71mG5SKZk0sBXxDK11IB 3RMusKLJbtYepuanExc0dX6snYCaD5Qe40MenppPZ4ZqgVx7I0CbAH+GQj3b0FfYcCV+ uk8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bf6si3399037plb.113.2019.05.09.09.23.33; Thu, 09 May 2019 09:23:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbfEIQWg (ORCPT + 99 others); Thu, 9 May 2019 12:22:36 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36452 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726469AbfEIQWf (ORCPT ); Thu, 9 May 2019 12:22:35 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 224DE14CF8672; Thu, 9 May 2019 09:22:35 -0700 (PDT) Date: Thu, 09 May 2019 09:22:34 -0700 (PDT) Message-Id: <20190509.092234.285409406486740265.davem@davemloft.net> To: jasowang@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yuehaibing@huawei.com, xiyou.wangcong@gmail.com, weiyongjun1@huawei.com, eric.dumazet@gmail.com Subject: Re: [PATCH net V3 1/2] tuntap: fix dividing by zero in ebpf queue selection From: David Miller In-Reply-To: <1557372018-18544-1-git-send-email-jasowang@redhat.com> References: <1557372018-18544-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 May 2019 09:22:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Wed, 8 May 2019 23:20:17 -0400 > We need check if tun->numqueues is zero (e.g for the persist device) > before trying to use it for modular arithmetic. > > Reported-by: Eric Dumazet > Fixes: 96f84061620c6("tun: add eBPF based queue selection method") > Signed-off-by: Jason Wang Applied and queued up for -stable.