Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 May 2019 20:00:05 +0200
From:   Corentin Labbe <clabbe.montjoie@gmail.com>
To:     Jose Abreu <Jose.Abreu@synopsys.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH net-next 00/11] net: stmmac: Selftests
Message-ID: <20190509180005.GA16272@Red>
References: <cover.1557300602.git.joabreu@synopsys.com>
 <20190509090416.GB1605@Red>
 <78EB27739596EE489E55E81C33FEC33A0B47AC7F@DE02WEMBXB.internal.synopsys.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B47AC7F@DE02WEMBXB.internal.synopsys.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 09, 2019 at 10:11:53AM +0000, Jose Abreu wrote:
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Thu, May 09, 2019 at 10:04:16
> 
> > What means 1 for "Perfect Filter UC" ?
> 
> Thank you for the testing :)
> 
> 1 means that either the expected packet was not received or that the 
> filter did not work.
> 
> For GMAC there is the need to set the HPF bit in order for the test to 
> pass. Do you have such bit in your HW ? It should be in EMAC_RX_FRM_FLT 
> register.

The problem was missing IFF_UNICAST_FLT, so netcore put the device in promiscous when adding an unicast address.

Next step will be to enable Flow Control, but I will start a new thread for that.

> 
> > I have added my patch below
> 
> Do you want me to add your patch to the series ? If you send me with 
> git-send-email I can apply it with your SoB.
> 

I will do.
I will send the patch for IFF_UNICAST_FLT appart since it fixes a bug.

Regards