Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1168815yba; Thu, 9 May 2019 11:53:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7ZAi8kIOla2/q5t3Ogx8RzYuMFe775rk/epYey3ttOtF5/lS+I2Gxvdhnxy1gfdcCRD+u X-Received: by 2002:a63:e711:: with SMTP id b17mr7818932pgi.202.1557428038165; Thu, 09 May 2019 11:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557428038; cv=none; d=google.com; s=arc-20160816; b=TeQ3M6jfsVGWR9iG35ck2XUio3HJBW0oyChsRDCSiEY7S2X4HBT+1ZzCPdHJpu7TYm ZVWsj+WgQIsrZUmExJq7YkHJc3BZ6Rn8tdJPBzL9pV6+MAXr2AutCUD3RryTCpNxFKSx rjgrU/aZx3JI430+wHTZhUA/2VmjJBIslQ6fFMQ+KgYI6Qx3U9f2nlSHFh+s6SUPi5uX jPG9irGRgOWq9d5TPVP5mL40PObXZdUpAlKwCIzrP0yZSBKncGE/WixVRqo4MjwY+KMm qOWdd55Vied4xE35W21fkhWB1aj7IjgDUpnLOrQESI/ZshH0OmJmQV08Hucd7Jw5msI8 +bYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4R+RGd9+F8zjY4I/Ir2RNoZk/MXf4yiaDEKdOf7LpMc=; b=Cw/W+lt0EksBeG1+WnSHcjeq2BSnh9CYypoeD2QeVeHtYjrncC50E85mxgIjd1g0/s HDyoTMkEza0GaOmrOHefs00JtECBm2StBOskO7pax0DRt/kW8MQRDT3wiGiTWxuIXB15 V3/SP8O09W3jDfEOnIWcCIXoHjzeK5pgN82Nv7eEgeb/Rwcl9oMvbyja8KYaBaYLMAhX w+w2cLQn+HgbF4QRkiiD/zENrViZri96/PwL7vy/h4Wy3E4HNDy3knJeJ+imOPTjuDC5 qlwS0rGGuQMHKB7xI0zGyUKCKBSAcUV/7jhRz7yMlQAmRYcdMHgktNQ076EPjDvIjvO9 F3Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ki2mdhfI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l64si4479473pge.159.2019.05.09.11.53.41; Thu, 09 May 2019 11:53:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ki2mdhfI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728568AbfEISvZ (ORCPT + 99 others); Thu, 9 May 2019 14:51:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727624AbfEISvY (ORCPT ); Thu, 9 May 2019 14:51:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E615720578; Thu, 9 May 2019 18:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427883; bh=JpAVFZ6+Wli+YK9/hbybuNC1kYcF1zZXCFLSOk8rjyk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ki2mdhfIoh4tWLuvBpZgo3CNGlmxZiWiaazNqOptEu6i0K3f9NO5a1BpJh8aFugCr anZFh+SzrSpYLfR11IhKe5iQ5lsdeM0RGXDg8zOE7lNptxe+LcXDxAC1vQ1Ai9vEac I9rYPSIvmw7TaOe3AEasckt8hZ7eKVYamRAv3xN4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Max Filippov , Sasha Levin Subject: [PATCH 5.0 40/95] xtensa: fix initialization of pt_regs::syscall in start_thread Date: Thu, 9 May 2019 20:41:57 +0200 Message-Id: <20190509181312.159187380@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181309.180685671@linuxfoundation.org> References: <20190509181309.180685671@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 2663147dc7465cb29040a05cc4286fdd839978b5 ] New pt_regs should indicate that there's no syscall, not that there's syscall #0. While at it wrap macro body in do/while and parenthesize macro arguments. Signed-off-by: Max Filippov Signed-off-by: Sasha Levin --- arch/xtensa/include/asm/processor.h | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/arch/xtensa/include/asm/processor.h b/arch/xtensa/include/asm/processor.h index f7dd895b2353e..0c14018d1c260 100644 --- a/arch/xtensa/include/asm/processor.h +++ b/arch/xtensa/include/asm/processor.h @@ -187,15 +187,18 @@ struct thread_struct { /* Clearing a0 terminates the backtrace. */ #define start_thread(regs, new_pc, new_sp) \ - memset(regs, 0, sizeof(*regs)); \ - regs->pc = new_pc; \ - regs->ps = USER_PS_VALUE; \ - regs->areg[1] = new_sp; \ - regs->areg[0] = 0; \ - regs->wmask = 1; \ - regs->depc = 0; \ - regs->windowbase = 0; \ - regs->windowstart = 1; + do { \ + memset((regs), 0, sizeof(*(regs))); \ + (regs)->pc = (new_pc); \ + (regs)->ps = USER_PS_VALUE; \ + (regs)->areg[1] = (new_sp); \ + (regs)->areg[0] = 0; \ + (regs)->wmask = 1; \ + (regs)->depc = 0; \ + (regs)->windowbase = 0; \ + (regs)->windowstart = 1; \ + (regs)->syscall = NO_SYSCALL; \ + } while (0) /* Forward declaration */ struct task_struct; -- 2.20.1