Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1177485yba; Thu, 9 May 2019 12:02:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqzcrnI6uYttjaroM64o3xZBj9cYQNZ/N8+1lgGxCdskD0o/Z/hR/RY8yIU5vUhDq/LMfUW0 X-Received: by 2002:a17:902:e00f:: with SMTP id ca15mr7569110plb.76.1557428576252; Thu, 09 May 2019 12:02:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557428576; cv=none; d=google.com; s=arc-20160816; b=MjNU3WYb4/zwkWpBON79+nLQhcm/Vu+dlmL3VuSvg4LoowvufGm2Y5kliqMZnLn8pF 2xMo3rRlNZb3rA7PRWKtKDdhjNUK7wcRg32p1mlthIRTS6nMLlNYwTpaJOMYhhMa3BOa 4RAVvXENAGEyHzxjQxTIqghR+zOmwR4FECwEntNJQO6AteIBtbczTCnEQmJUsAiHim2v u27Ni2abvizO9xAMhAX6h62JSWDrlK8E+P5T0Hqt7DIcm0lmtVe/3ysb075P4ATKqrqd lbpwN5JmkgtiAvSbf8AVFKoXSuxclSc4daRUd17FJadGmxGISHnzjl/EbrlGO/Sb+6fy Gypw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NBrDeOSnRXQ7Y9CAJRgYCsG7NpRu9+F7JBXsEK3xkKo=; b=bER3AUm7gnonn35OpHmLoQ3eqGtSYXoFfln6UKpX/jbrQfsjKWYsK7LLdg6+C8H7ni YBgSs5XMC8mRj1dml3VBuni0KuUd7GlzGqzk1/L2Bq0+STllKbkVpmUvn7/onqUmxilg ilc97QbqUSpOCNGpnSdCjP+ZxKeWTrUca/nMZT1WFb5DAinTE4VyasepIQGaCeJWejSD 90L9vltO41YPH6z9RkUMy4qGniiD9BKKl28bXiALp0aN0dJ1d/UdTOFZaXAazArkhY+v 8FHD7rW1xdrabeBeRMgC65Gm/tpAtUY9OIFuj+AJHlNcBs+KD2JRxEuhooQdtxx4xaYQ +3SQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oZWXEss1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f91si4319888plb.20.2019.05.09.12.02.38; Thu, 09 May 2019 12:02:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oZWXEss1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbfEIS75 (ORCPT + 99 others); Thu, 9 May 2019 14:59:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:45976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728646AbfEISwD (ORCPT ); Thu, 9 May 2019 14:52:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D1D420578; Thu, 9 May 2019 18:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427922; bh=ITVC5MyQebwwuTYGEQFN5WcrGNso+TLT3BOfYFjDfVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oZWXEss19EZiiI0qFReO+uN21lQHOG2QHcMgBghE1Dgh5mOsbHFAlDuovyDilZgWF +X4HCYtbCWnNI/SLFwdvdteleMP+/0jpsnisgtYEk3NXrJJpNN3Dbc6pezRVSN2QV7 J3zuyoWL+p/nRcq1a0H61FhN8Zc/nZe2n7dzOJMs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Varun Prakash , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.0 54/95] scsi: csiostor: fix missing data copy in csio_scsi_err_handler() Date: Thu, 9 May 2019 20:42:11 +0200 Message-Id: <20190509181313.292815070@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181309.180685671@linuxfoundation.org> References: <20190509181309.180685671@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5c2442fd78998af60e13aba506d103f7f43f8701 ] If scsi cmd sglist is not suitable for DDP then csiostor driver uses preallocated buffers for DDP, because of this data copy is required from DDP buffer to scsi cmd sglist before calling ->scsi_done(). Signed-off-by: Varun Prakash Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/csiostor/csio_scsi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c index bc5547a62c00c..c54c6cd504c41 100644 --- a/drivers/scsi/csiostor/csio_scsi.c +++ b/drivers/scsi/csiostor/csio_scsi.c @@ -1713,8 +1713,11 @@ csio_scsi_err_handler(struct csio_hw *hw, struct csio_ioreq *req) } out: - if (req->nsge > 0) + if (req->nsge > 0) { scsi_dma_unmap(cmnd); + if (req->dcopy && (host_status == DID_OK)) + host_status = csio_scsi_copy_to_sgl(hw, req); + } cmnd->result = (((host_status) << 16) | scsi_status); cmnd->scsi_done(cmnd); -- 2.20.1