Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1178529yba; Thu, 9 May 2019 12:03:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEUxASfmRybzCSUHv+P9JJ4c70SzIfQ+BfjBxE99LLwEgIeCADBxanUT82dLbVVg6uIBv/ X-Received: by 2002:a62:2ad5:: with SMTP id q204mr7599167pfq.259.1557428634460; Thu, 09 May 2019 12:03:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557428634; cv=none; d=google.com; s=arc-20160816; b=mjrVxdSUoQ8zwli+tqh2GuBfNbxsVlok0RkLf0Kq7WboaCMzg7O9JnftFz4bul4m5B O6qSfzxgCgpz9icstmz7hvhi6iHJCOlOxxkPhT3kFyL1MAul/IvkG/v9zzpExd6B2cD7 zMqNaDBUkO7mm8ZoEasr3Pm9KzQDW4XvY6M3RzQsUaX1EdBhnE4ovjzWhSsaJcrKzaeQ zgDAIg2PhxGvay9VZLiEyfVDLq6wJ80lWjNaImp1ygcmoh4ZkSU3JkKcQXnzeh1lPxwP OqMJMLG/dslYVPnc3L0aCR0cQEd57l5GY0+RJ4m6IkN5QUS/12TAzwn9FJ3wStgWh7hH 7o1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=y0b0Fnz0yl/2JalVI7Yy/kSmuncdtS+V8otDdfG+31E=; b=wnnFiFo1w4HuCxcRkQBrQoU6E7Ug29dYdMnoRUWVlFKmoVRT+fxoP8+EmoRqS4rtOv Bk6QZzlROn7+wuMI9TFnd0RM7vf+PGJcv5+AQWHhHvtPUsDqMtv1A2UPdFClqdkMZ+Sv ggO5/LIurPRXXSQSFvSa9LnOxd3xDFBBDqlJsUkiIQfSglvN96bYnx2/9Zw75zHh9ozQ 5CITwj7y7dBjR6+lhcblAKrrCXbgmgPxYQn4AIWtYTx2ZIND7PhUZJlB7RJBkdJT4pxg NF2oEWe1mSMRT9X1S/9WyLEddgZFPDRYJENk7kSg62KzzQWqesBYHaCOENGBG22IZ4/N X71g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=McwEYcXw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c139si4107736pfb.161.2019.05.09.12.03.38; Thu, 09 May 2019 12:03:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=McwEYcXw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726966AbfEISu0 (ORCPT + 99 others); Thu, 9 May 2019 14:50:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:43868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727693AbfEISuW (ORCPT ); Thu, 9 May 2019 14:50:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC45020578; Thu, 9 May 2019 18:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427821; bh=uA4kEIfZo9TbnlF7NqgBQomYfFPlnVNdd7ai6kUB0o0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=McwEYcXwWpta9OKjE7nfoigd+OqiKUMN99qPs05J7ubxNt6TQwwVgX3+bgsRKFl4z BMX7W3sWNVfx+VqGtjwIxcUADHM6sGz8nnsxi4CxTA1LviI8Po7imwqYcQ4gPiFXRk PBcx4Zm52lY37v5zRBaYPp+hOnYq8gusuugK5A/8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, John Hsu , Mark Brown , Sasha Levin Subject: [PATCH 5.0 17/95] ASoC: nau8824: fix the issue of the widget with prefix name Date: Thu, 9 May 2019 20:41:34 +0200 Message-Id: <20190509181310.549089444@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181309.180685671@linuxfoundation.org> References: <20190509181309.180685671@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 844a4a362dbec166b44d6b9b3dd45b08cb273703 ] The driver has two issues when machine add prefix name for codec. (1)The stream name of DAI can't find the AIF widgets. (2)The drivr can enable/disalbe the MICBIAS and SAR widgets. The patch will fix these issues caused by prefixed name added. Signed-off-by: John Hsu Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/nau8824.c | 46 +++++++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 468d5143e2c4f..663a208c2f784 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -681,8 +681,8 @@ static const struct snd_soc_dapm_widget nau8824_dapm_widgets[] = { SND_SOC_DAPM_ADC("ADCR", NULL, NAU8824_REG_ANALOG_ADC_2, NAU8824_ADCR_EN_SFT, 0), - SND_SOC_DAPM_AIF_OUT("AIFTX", "HiFi Capture", 0, SND_SOC_NOPM, 0, 0), - SND_SOC_DAPM_AIF_IN("AIFRX", "HiFi Playback", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("AIFTX", "Capture", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_IN("AIFRX", "Playback", 0, SND_SOC_NOPM, 0, 0), SND_SOC_DAPM_DAC("DACL", NULL, NAU8824_REG_RDAC, NAU8824_DACL_EN_SFT, 0), @@ -831,6 +831,36 @@ static void nau8824_int_status_clear_all(struct regmap *regmap) } } +static void nau8824_dapm_disable_pin(struct nau8824 *nau8824, const char *pin) +{ + struct snd_soc_dapm_context *dapm = nau8824->dapm; + const char *prefix = dapm->component->name_prefix; + char prefixed_pin[80]; + + if (prefix) { + snprintf(prefixed_pin, sizeof(prefixed_pin), "%s %s", + prefix, pin); + snd_soc_dapm_disable_pin(dapm, prefixed_pin); + } else { + snd_soc_dapm_disable_pin(dapm, pin); + } +} + +static void nau8824_dapm_enable_pin(struct nau8824 *nau8824, const char *pin) +{ + struct snd_soc_dapm_context *dapm = nau8824->dapm; + const char *prefix = dapm->component->name_prefix; + char prefixed_pin[80]; + + if (prefix) { + snprintf(prefixed_pin, sizeof(prefixed_pin), "%s %s", + prefix, pin); + snd_soc_dapm_force_enable_pin(dapm, prefixed_pin); + } else { + snd_soc_dapm_force_enable_pin(dapm, pin); + } +} + static void nau8824_eject_jack(struct nau8824 *nau8824) { struct snd_soc_dapm_context *dapm = nau8824->dapm; @@ -839,8 +869,8 @@ static void nau8824_eject_jack(struct nau8824 *nau8824) /* Clear all interruption status */ nau8824_int_status_clear_all(regmap); - snd_soc_dapm_disable_pin(dapm, "SAR"); - snd_soc_dapm_disable_pin(dapm, "MICBIAS"); + nau8824_dapm_disable_pin(nau8824, "SAR"); + nau8824_dapm_disable_pin(nau8824, "MICBIAS"); snd_soc_dapm_sync(dapm); /* Enable the insertion interruption, disable the ejection @@ -870,8 +900,8 @@ static void nau8824_jdet_work(struct work_struct *work) struct regmap *regmap = nau8824->regmap; int adc_value, event = 0, event_mask = 0; - snd_soc_dapm_force_enable_pin(dapm, "MICBIAS"); - snd_soc_dapm_force_enable_pin(dapm, "SAR"); + nau8824_dapm_enable_pin(nau8824, "MICBIAS"); + nau8824_dapm_enable_pin(nau8824, "SAR"); snd_soc_dapm_sync(dapm); msleep(100); @@ -882,8 +912,8 @@ static void nau8824_jdet_work(struct work_struct *work) if (adc_value < HEADSET_SARADC_THD) { event |= SND_JACK_HEADPHONE; - snd_soc_dapm_disable_pin(dapm, "SAR"); - snd_soc_dapm_disable_pin(dapm, "MICBIAS"); + nau8824_dapm_disable_pin(nau8824, "SAR"); + nau8824_dapm_disable_pin(nau8824, "MICBIAS"); snd_soc_dapm_sync(dapm); } else { event |= SND_JACK_HEADSET; -- 2.20.1