Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1183400yba; Thu, 9 May 2019 12:08:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzr8K5TaSkuil22mkEoomyXw13F74Biz+CH+LPW+pzydbU1+tYDi7roliZyLVUbrOjg9erk X-Received: by 2002:a63:4562:: with SMTP id u34mr7694435pgk.354.1557428890481; Thu, 09 May 2019 12:08:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557428890; cv=none; d=google.com; s=arc-20160816; b=ZfTsrEeLg6PBbpjFuUfPlQwlgjotaVWMWigROxayFbc0eIKKp63ffPYvcBXkTa0LQA +EIBP6Rn1Oh28cKxzVgtTfaIbf7xifATAaXVCn1kCTx0rufgNDXdE7wD3deCMy+pFPxv n9n9QjLqSNeBO4eRe7IdGmN8yi+wzSgzgRSIQsEZzfk+8+NIbHO6NTiHgYP2AeYFHvmz fQK4kf3yySkzaWzuf++CSyKJuvNzHJMBCdaANBX779ts5RGAiZufcZHUUXOMLUYo8wTM Tes3JgmG+JP4+7Y0VmlCrMeWDFBfGmVAgswyvXrMaI+kCtfII0bouB2/P63ZplruRb8+ L6OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pN21L+COiEwMiXv5XhtRIi8vvDLQx+RT4niyzkslrCs=; b=ksotlXGh2tYx1JgVnO+j07esOB10OIm29dNiuuuXU/LjmNv7f8WmdlbAGmPqO585Gi yDfMJqxuZGWlxMiTrSH4rK6CAZq4yKDt1icdghUlvtZACv/1hEwqPzd8MlEMQDKo9X5W mE1V5bR9HpbQ3B9C/UYtgrlh7DUg6BTWYMWpJ/Yww1f/o1humomvOLED40GsW0dqezHL IrwCAuUIuQ2jD4qnrzEA1rokGQ7smDsvYTLQBdQVlr1QYTJLWSjS/F1uhVA1Ixm8tAUO APgGJmwe385I41neSY32wlpqYxoRlNFCOgoS9Ywfp992o9VOeKH2n50Eece9sRUiGSPN XCxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xrRxnBN4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si4315445pgi.26.2019.05.09.12.07.54; Thu, 09 May 2019 12:08:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xrRxnBN4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727554AbfEISqT (ORCPT + 99 others); Thu, 9 May 2019 14:46:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:38564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727546AbfEISqQ (ORCPT ); Thu, 9 May 2019 14:46:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BFB9217F5; Thu, 9 May 2019 18:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427576; bh=PfIkP7KuBLwBB46NxQMftxKVlqvw4HiH02nzRntN+r4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xrRxnBN4b4U0koWxB44YgVqEG+6SbpkvTLvOTdMBlwLxdJ9pBFc9RCcqFU4lCxaAM vVSHLLQwEG81/xivf5yGCDvB6s9/WQXNLayPLzPvTu1x0dMNnKBuYGX6A3QqBrT9xP Wqk50fASNzf5vGvSgJsH4/LAV2YXLOzhj7Ih+6qg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, John Hsu , Mark Brown , Sasha Levin Subject: [PATCH 4.14 07/42] ASoC: nau8824: fix the issue of the widget with prefix name Date: Thu, 9 May 2019 20:41:56 +0200 Message-Id: <20190509181254.109239930@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181252.616018683@linuxfoundation.org> References: <20190509181252.616018683@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 844a4a362dbec166b44d6b9b3dd45b08cb273703 ] The driver has two issues when machine add prefix name for codec. (1)The stream name of DAI can't find the AIF widgets. (2)The drivr can enable/disalbe the MICBIAS and SAR widgets. The patch will fix these issues caused by prefixed name added. Signed-off-by: John Hsu Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/nau8824.c | 46 +++++++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 0240759f951c7..e8ea51247b179 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -634,8 +634,8 @@ static const struct snd_soc_dapm_widget nau8824_dapm_widgets[] = { SND_SOC_DAPM_ADC("ADCR", NULL, NAU8824_REG_ANALOG_ADC_2, NAU8824_ADCR_EN_SFT, 0), - SND_SOC_DAPM_AIF_OUT("AIFTX", "HiFi Capture", 0, SND_SOC_NOPM, 0, 0), - SND_SOC_DAPM_AIF_IN("AIFRX", "HiFi Playback", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("AIFTX", "Capture", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_IN("AIFRX", "Playback", 0, SND_SOC_NOPM, 0, 0), SND_SOC_DAPM_DAC("DACL", NULL, NAU8824_REG_RDAC, NAU8824_DACL_EN_SFT, 0), @@ -784,6 +784,36 @@ static void nau8824_int_status_clear_all(struct regmap *regmap) } } +static void nau8824_dapm_disable_pin(struct nau8824 *nau8824, const char *pin) +{ + struct snd_soc_dapm_context *dapm = nau8824->dapm; + const char *prefix = dapm->component->name_prefix; + char prefixed_pin[80]; + + if (prefix) { + snprintf(prefixed_pin, sizeof(prefixed_pin), "%s %s", + prefix, pin); + snd_soc_dapm_disable_pin(dapm, prefixed_pin); + } else { + snd_soc_dapm_disable_pin(dapm, pin); + } +} + +static void nau8824_dapm_enable_pin(struct nau8824 *nau8824, const char *pin) +{ + struct snd_soc_dapm_context *dapm = nau8824->dapm; + const char *prefix = dapm->component->name_prefix; + char prefixed_pin[80]; + + if (prefix) { + snprintf(prefixed_pin, sizeof(prefixed_pin), "%s %s", + prefix, pin); + snd_soc_dapm_force_enable_pin(dapm, prefixed_pin); + } else { + snd_soc_dapm_force_enable_pin(dapm, pin); + } +} + static void nau8824_eject_jack(struct nau8824 *nau8824) { struct snd_soc_dapm_context *dapm = nau8824->dapm; @@ -792,8 +822,8 @@ static void nau8824_eject_jack(struct nau8824 *nau8824) /* Clear all interruption status */ nau8824_int_status_clear_all(regmap); - snd_soc_dapm_disable_pin(dapm, "SAR"); - snd_soc_dapm_disable_pin(dapm, "MICBIAS"); + nau8824_dapm_disable_pin(nau8824, "SAR"); + nau8824_dapm_disable_pin(nau8824, "MICBIAS"); snd_soc_dapm_sync(dapm); /* Enable the insertion interruption, disable the ejection @@ -822,8 +852,8 @@ static void nau8824_jdet_work(struct work_struct *work) struct regmap *regmap = nau8824->regmap; int adc_value, event = 0, event_mask = 0; - snd_soc_dapm_force_enable_pin(dapm, "MICBIAS"); - snd_soc_dapm_force_enable_pin(dapm, "SAR"); + nau8824_dapm_enable_pin(nau8824, "MICBIAS"); + nau8824_dapm_enable_pin(nau8824, "SAR"); snd_soc_dapm_sync(dapm); msleep(100); @@ -834,8 +864,8 @@ static void nau8824_jdet_work(struct work_struct *work) if (adc_value < HEADSET_SARADC_THD) { event |= SND_JACK_HEADPHONE; - snd_soc_dapm_disable_pin(dapm, "SAR"); - snd_soc_dapm_disable_pin(dapm, "MICBIAS"); + nau8824_dapm_disable_pin(nau8824, "SAR"); + nau8824_dapm_disable_pin(nau8824, "MICBIAS"); snd_soc_dapm_sync(dapm); } else { event |= SND_JACK_HEADSET; -- 2.20.1