Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1185255yba; Thu, 9 May 2019 12:09:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJ8yMcPKHbeSUGOv2S23DBZgrLu6bbzYWjezf1dG3JtrOLg6v5/ezfu+xmRnR+EbHYJKia X-Received: by 2002:a63:dd58:: with SMTP id g24mr7845696pgj.161.1557428996065; Thu, 09 May 2019 12:09:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557428996; cv=none; d=google.com; s=arc-20160816; b=BLxF+NsYNqHGYR5vBIisIh8g9B952fca6skksZzd6o5+fKBiG4jhZPEc7FJ1PNWaSM rChoqHHS18e5avaCzYpG66WAzAT9gBWrEO0kzM3eEN4PQwcNefjXLgUZ3F7R2GatNePv GLyCBm29Hl6H9UCB8fIwHi6dWA/4rUUA3yepRSZyHcsRMzZHdGF2TO9hWRg5Pb+QZCPU X7qDqIIFd/nOBTCyg4qhBaDce/lChQMhKVb9dgYwf5PanNlYn2l8rZM5IQ/O1Ye2mEzR /X8fmp5nWQI2Zqq7EdXocEKyP2JsKBqRzc0EeUjMY0akPRnO9hIBjSn3brQExfAp7ys0 pmvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UWMx07UvsVVsYu1XcBCqQbldykw4Moo4qlJbHMkeuJk=; b=RXMioJeugWqpAEZRqqnw5Zh4w7bhrOa628oqjxVlkM2oTK5aIlrSmpmlJHmO+noVvY deCkiTqMbmqTnh3qIWVBI9ekPHEG4T2vLISHpA9ihKPEyD6gTmAw8A23eusJV/r8vORg zsh7z/XebdKmMYDLycGwzgkwJ05KfvGJAMgILYJKvSTEzcMf1ncKcPFRYpMeA7QjSlGo PMx36J9bgb8G/F57gDKFhSytb8wtiKVTwBhvXKw6nHTN+4GTdGthDUFVtKswBqjMkDtM TzzGUG54uvfF4HoBXnyDgf/fOJCWyCV4J3+Hbn+oPaqgWIBNMOecdYs7e//xm5xoWerk 4JQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzG4xRsd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g132si4095892pfc.260.2019.05.09.12.09.39; Thu, 09 May 2019 12:09:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzG4xRsd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbfEISoi (ORCPT + 99 others); Thu, 9 May 2019 14:44:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:36012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbfEISoe (ORCPT ); Thu, 9 May 2019 14:44:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13F10217D6; Thu, 9 May 2019 18:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427473; bh=hEuToZTYTh+72tR79gRIV7bx32NRmE1y/XhSGpfYvRw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zzG4xRsdUvGkJcSCHdYm+SB7DsBsnY3B+B3Z/Cidqh8n/NQ5CnFVYP0IPW0UTLtR6 KQLKd3rEtOSDJui2cXAACxXOw2CvlzfQAM1T8Fc6gqI2GNGRgIHCvaRa1r3dHl0mB5 XVpPlHw7g2MkaFvGeUJ6U/3zEIFvsusxRBuUHFgA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Vasquez , Himanshu Madhani , "Martin K. Petersen" Subject: [PATCH 4.9 23/28] scsi: qla2xxx: Fix incorrect region-size setting in optrom SYSFS routines Date: Thu, 9 May 2019 20:42:15 +0200 Message-Id: <20190509181255.186877923@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181247.647767531@linuxfoundation.org> References: <20190509181247.647767531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Vasquez commit 5cbdae10bf11f96e30b4d14de7b08c8b490e903c upstream. Commit e6f77540c067 ("scsi: qla2xxx: Fix an integer overflow in sysfs code") incorrectly set 'optrom_region_size' to 'start+size', which can overflow option-rom boundaries when 'start' is non-zero. Continue setting optrom_region_size to the proper adjusted value of 'size'. Fixes: e6f77540c067 ("scsi: qla2xxx: Fix an integer overflow in sysfs code") Cc: stable@vger.kernel.org Signed-off-by: Andrew Vasquez Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_attr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -345,7 +345,7 @@ qla2x00_sysfs_write_optrom_ctl(struct fi } ha->optrom_region_start = start; - ha->optrom_region_size = start + size; + ha->optrom_region_size = size; ha->optrom_state = QLA_SREADING; ha->optrom_buffer = vmalloc(ha->optrom_region_size); @@ -418,7 +418,7 @@ qla2x00_sysfs_write_optrom_ctl(struct fi } ha->optrom_region_start = start; - ha->optrom_region_size = start + size; + ha->optrom_region_size = size; ha->optrom_state = QLA_SWRITING; ha->optrom_buffer = vmalloc(ha->optrom_region_size);