Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 09 May 2019 13:46:46 -0700 (PDT)
Message-Id: <20190509.134646.706587781958620517.davem@davemloft.net>
To:     yuehaibing@huawei.com
Cc:     willemb@google.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, edumazet@google.com, maximmi@mellanox.com
Subject: Re: [PATCH v2] packet: Fix error path in packet_init
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190509145220.37432-1-yuehaibing@huawei.com>
References: <20190508153241.30776-1-yuehaibing@huawei.com>
        <20190509145220.37432-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 9 May 2019 22:52:20 +0800

> kernel BUG at lib/list_debug.c:47!
 ...
> When modprobe af_packet, register_pernet_subsys
> fails and does a cleanup, ops->list is set to LIST_POISON1,
> but the module init is considered to success, then while rmmod it,
> BUG() is triggered in __list_del_entry_valid which is called from
> unregister_pernet_subsys. This patch fix error handing path in
> packet_init to avoid possilbe issue if some error occur.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: rework commit log

Applied and queued up for -stable, thank you.