Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 May 2019 10:41:04 +1000
From:   "Tobin C. Harding" <tobin@kernel.org>
To:     "Tobin C. Harding" <tobin@kernel.org>
Cc:     Jonathan Corbet <corbet@lwn.net>, Corey Minyard <minyard@acm.org>,
        Thomas Hellstrom <thellstrom@vmware.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: Move kref.txt to core-api/kref.rst
Message-ID: <20190510004104.GA12809@eros.localdomain>
References: <20190510001747.8767-1-tobin@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190510001747.8767-1-tobin@kernel.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 10, 2019 at 10:17:47AM +1000, Tobin C. Harding wrote:
> kref.txt is already written using correct ReStructuredText format.  This
> can be verified as follows
> 
> 	make cleandocs
> 	make htmldocs 2> pre.stderr
> 	mv Documentation/kref.txt Documentation/core-api/kref.rst
> 	// Add 'kref' to core-api/index.rst
> 	make cleandocs
> 	make htmldocs 2> post.stderr
> 	diff pre.stderr post.stderr
> 
> While doing the file move, fix the column width to be 72 characters wide
> as it is throughout the document.  This is whitespace only.  kref.txt is
> so cleanly written its a shame to have these few extra wide paragraphs.
> 
> Signed-off-by: Tobin C. Harding <tobin@kernel.org>
> ---
> 
> I'm always hesitant to do docs patches that seem obvious - is there
> some reason that this was not done previously?
> 
> I did this one in preparation for converting kobject.txt, my intent is
> to put kboject.rst in core-api/ also?

Oh, I should have started on kobject.rst before sending this.  It builds
without errors also.  The 'conversion' is no more than renaming the
file.

If this patch is acceptable I can re-spin it as part of a series that
does kobject as well so you don't get merge conflicts in core-api/index

thanks,
Tobin.