Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Manish Rangankar <mrangankar@marvell.com>
To:     Yue Haibing <yuehaibing@huawei.com>,
        "QLogic-Storage-Upstream@cavium.com" 
        <QLogic-Storage-Upstream@cavium.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH -next] scsi: qedi: remove set but not used variables
 'cdev' and 'udev'
Thread-Topic: [PATCH -next] scsi: qedi: remove set but not used variables
 'cdev' and 'udev'
Thread-Index: AQHU+nQ89AUI/NIlBkC1079Ec+hhQaZj7UWg
Date:   Fri, 10 May 2019 05:28:18 +0000
Message-ID: <BYAPR18MB248596EAD386EC09F380162DD80C0@BYAPR18MB2485.namprd18.prod.outlook.com>
References: <20190424080256.30012-1-yuehaibing@huawei.com>
In-Reply-To: <20190424080256.30012-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 80582d1a-d818-46c5-b337-08d6d5084f93
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2019 05:28:18.9379
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2887
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-09_02:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org <linux-scsi-
> owner@vger.kernel.org> On Behalf Of Yue Haibing
> Sent: Wednesday, April 24, 2019 1:33 PM
> To: QLogic-Storage-Upstream@cavium.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [PATCH -next] scsi: qedi: remove set but not used variables 'cde=
v'
> and 'udev'
>=20
> From: YueHaibing <yuehaibing@huawei.com>
>=20
> Fixes gcc '-Wunused-but-set-variable' warning:
>=20
> drivers/scsi/qedi/qedi_iscsi.c: In function 'qedi_ep_connect':
> drivers/scsi/qedi/qedi_iscsi.c:813:23: warning: variable 'udev' set but n=
ot
> used [-Wunused-but-set-variable]
> drivers/scsi/qedi/qedi_iscsi.c:812:18: warning: variable 'cdev' set but n=
ot
> used [-Wunused-but-set-variable]
>=20
> They are never used since introduction.
>=20
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/scsi/qedi/qedi_iscsi.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscs=
i.c
> index e4391ee..688a6d8 100644
> --- a/drivers/scsi/qedi/qedi_iscsi.c
> +++ b/drivers/scsi/qedi/qedi_iscsi.c
> @@ -809,8 +809,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
>  	struct qedi_endpoint *qedi_ep;
>  	struct sockaddr_in *addr;
>  	struct sockaddr_in6 *addr6;
> -	struct qed_dev *cdev  =3D  NULL;
> -	struct qedi_uio_dev *udev =3D NULL;
>  	struct iscsi_path path_req;
>  	u32 msg_type =3D ISCSI_KEVENT_IF_DOWN;
>  	u32 iscsi_cid =3D QEDI_CID_RESERVED;
> @@ -830,8 +828,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
>  	}
>=20
>  	qedi =3D iscsi_host_priv(shost);
> -	cdev =3D qedi->cdev;
> -	udev =3D qedi->udev;
>=20
>  	if (test_bit(QEDI_IN_OFFLINE, &qedi->flags) ||
>  	    test_bit(QEDI_IN_RECOVERY, &qedi->flags)) {
> --
> 2.7.4
>=20

Thanks,

Acked-by: Manish Rangankar <mrangankar@marvell.com>