Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     Leonard Crestez <leonard.crestez@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        "stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
        "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "heiko@sntech.de" <heiko@sntech.de>,
        "marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
        "ezequiel@collabora.com" <ezequiel@collabora.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        Andy Gross <andy.gross@linaro.org>,
        "jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "olof@lixom.net" <olof@lixom.net>,
        "horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH 1/2] soc: imx-sc: add i.MX system controller soc driver
 support
Thread-Topic: [PATCH 1/2] soc: imx-sc: add i.MX system controller soc driver
 support
Thread-Index: AQHU+KWWicVqVQQzP0ClKRUbB9ME9qZjwquAgABQeoA=
Date:   Fri, 10 May 2019 07:30:20 +0000
Message-ID: <20190510073019.rkf6zxkxoj4sgxpy@fsr-ub1664-175>
References: <1554965048-19450-1-git-send-email-Anson.Huang@nxp.com>
 <20190421073958.GC19962@dragon> <20190421074152.GD19962@dragon>
 <DB3PR0402MB39161C0DDFF0EEA6D8A90378F5220@DB3PR0402MB3916.eurprd04.prod.outlook.com>
 <DB3PR0402MB39164B30B26CAF62EE807168F5220@DB3PR0402MB3916.eurprd04.prod.outlook.com>
 <VI1PR04MB5533CED52723AE8292CFC305EE220@VI1PR04MB5533.eurprd04.prod.outlook.com>
 <20190510024215.GA15856@dragon>
In-Reply-To: <20190510024215.GA15856@dragon>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <69A407636461B248A9D298170B2FC4BD@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 57db8cd2-ed1d-416b-34ae-08d6d5195ba4
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2019 07:30:20.5901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4289
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19-05-10 10:42:17, Shawn Guo wrote:
> On Mon, Apr 22, 2019 at 08:48:56AM +0000, Leonard Crestez wrote:
> > On 4/22/2019 9:46 AM, Anson Huang wrote:
> > >> -----Original Message-----
> > >> From: Anson Huang
> > >>> From: Shawn Guo [mailto:shawnguo@kernel.org]
> > >>> On Sun, Apr 21, 2019 at 03:40:00PM +0800, Shawn Guo wrote:
> > >>>> On Thu, Apr 11, 2019 at 06:49:12AM +0000, Anson Huang wrote:
> > >>>>> i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> > >>>>> inside, the system controller is in charge of controlling power,
> > >>>>> clock and fuse etc..
> > >>>>>
> > >>>>> This patch adds i.MX system controller soc driver support, Linux
> > >>>>> kernel has to communicate with system controller via MU (message
> > >>>>> unit) IPC to get soc revision, uid etc..
> > >>>>>
> > >>>>> With this patch, soc info can be read from sysfs:
> > >>>>>
> > >>>>>   drivers/soc/imx/Kconfig      |   7 ++
> > >>>>>   drivers/soc/imx/Makefile     |   1 +
> > >>>>>   drivers/soc/imx/soc-imx-sc.c | 220
> > >>>>> +++++++++++++++++++++++++++++++++++++++++++
> > >>>>>   3 files changed, 228 insertions(+)  create mode 100644
> > >>>>> drivers/soc/imx/soc-imx-sc.c
> > >>>>
> > >>>> Rather than creating a new driver, please take a look at Abel's
> > >>>> generic
> > >>>> i.MX8 SoC driver, and see if it can be extended to cover i.MX8QXP.
> > >>
> > >> Got it, I didn't notice that this patch bas been accepted, I will re=
do the patch
> > >> based on it, thanks.
> > >=20
> > > I have sent the new patch set to support i.MX8QXP SoC revision based =
on generic i.MX8
> > > SoC driver, however, the Kconfig modification is NOT good, it may bre=
ak i.MX8MQ if IMX_SCU
> > > is NOT enabled, although we can add some warp function for SCU firmwa=
re API call to fix it,
> > > but after further thought and discussion with Dong Aisheng, I think w=
e may need to roll back to
> > > use this patch series to create a new SoC driver dedicated for i.MX8 =
SoCs
> > > with system controller inside, such as i.MX8QXP, i.MX8QM etc., the re=
ason are as below:
> > >=20
> > > For i.MX8MQ/i.MX8MM:
> > > 	1. SoC driver does NOT depends on i.MX SCU firmware, so no need to u=
se platform driver
> > > 	     probe model, just device_init phase call is good enough;
> > > 	2. The SoC driver no need to depends on IMX_SCU, so it can be always=
 built in, no need to
> > > 	     check IMX_SCU config;
> > > 	3. The fuse check for CPU speed grading, HDCP status, NoC settings e=
tc. could be added to this driver,
> > > 	    but they are ONLY for i.MX8MQ/i.MX8MM etc..
> > > For i.MX8QXP/i.MX8QM:
> > > 	1. SoC driver MUST depends on IMX_SCU;
> > > 	2. MUST use platform model to support defer probe;
> > > 	3. No fuse check for CPU speed grading.
> > >=20
> > > So, I guess the reused code for i.MX8MQ and i.MX8QXP is ONLY those pa=
rt of creating SoC id device node (less than
> > > 30% I think), all other functions are implemented in total different =
ways, that is why I created the imx_sc_soc driver
> > > in this patch series, so do you think we can add new SoC driver for i=
.MX8 SoC with SCU inside? Putting 2 different architecture
> > > SoCs' driver into 1 file looks like NOT making enough sense.
> >=20
> > +1 for separate SOC driver. The 8mq/8mm and 8qm/8qxp families are very=
=20
> > different, they just happen to share the imx8 prefix.
> >=20
> > It makes sense to allow people to compile one without the other and thi=
s=20
> > is easier with distinct SOC drivers.

Totally agree.

>=20
> Leonard, Abel,
>=20
> Can you guys help review the patch?  Thanks.
>=20
> Shawn

Looks good to me.

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>=