Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1872845yba; Fri, 10 May 2019 02:28:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+o5Oj9ebpLsbKnJKOVDjYdOxxz50RbaHYZtnNF3UPjLPXrpC/A6JqhQ9AAezA0+SQmhXx X-Received: by 2002:a17:902:7682:: with SMTP id m2mr11412485pll.68.1557480492743; Fri, 10 May 2019 02:28:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557480492; cv=none; d=google.com; s=arc-20160816; b=uDKYkIGevpYrhaPK/LPOkI8kooB4V4buUzhvhHH7H0Z2Xdjh8RZ5Xy+RvPH/cVAv// p/DMwKQgiytPfCn6R5HkrBbXz6lJm459PHU9w1BTrtPL2OlE/5RsXxfvRtAPWyvWEWgg I8qG26E26u9ySI1XMnKrhFob/wiBS/kVUQ3f/9L9XWjoIc+6ziFDOiC5GdPMxb2bLwuF QzQ1QbeGuzoxaYvR0gKKR4nrus2AG4E0pEiEustZlE7oMW1Dxwu1jrGSk6wu/Sy6iVr6 dSghfHyuGrIqZ7KPRBHKbMT95kkKlqeXlCzzJFrJAyOHakE/vcZoCkSuq5dzGS2FhBY7 4ZKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:message-id :dkim-signature; bh=7+rPkb2mMCN5fVEdeNW5Bv+959x/xuLC/xkQspJWIF4=; b=Q/dVfbKy9XbS8ZdKRy2NPhk7D6EsuRE9ZwCCxTmtcslZriVwlRuabNw/yzWA38ova3 Cy8DOwey8adGMdz/qAG5A3JlWaK0hEw++f2OaH6mZAvjm91qc3cX+MbI/drmfa2Jw3Vj +ci6TD/gRUGJxl87RPNBXwJbAZvfC23qt/ZubmQBCZYSOV3+oJPBNHDWKL1TNxIDNakL WC8a1+DQ8c/GtdoHQ7ZY5kIxg0kjO+IcV9VgCYiuV9mKTSwb/o1EpFlicYsNccwuWbKZ mYuViIXFLVRY55+8qiiaAGP8zWFRiAuCQi0s7lrinbuwDi5h/BgjZvfdWRQHlQoo479v /UmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=taWSJ99P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 74si6431274pga.291.2019.05.10.02.27.56; Fri, 10 May 2019 02:28:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=taWSJ99P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727299AbfEJJYv (ORCPT + 99 others); Fri, 10 May 2019 05:24:51 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:34576 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727160AbfEJJYu (ORCPT ); Fri, 10 May 2019 05:24:50 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 450lD01KCKz9v1Mt; Fri, 10 May 2019 11:24:48 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=taWSJ99P; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id KJXQjKtTJ41s; Fri, 10 May 2019 11:24:48 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 450lD00HK7z9v1MX; Fri, 10 May 2019 11:24:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1557480288; bh=7+rPkb2mMCN5fVEdeNW5Bv+959x/xuLC/xkQspJWIF4=; h=From:Subject:To:Cc:Date:From; b=taWSJ99PKG67Av4raH7KIE+Cms6j4wKbf27OdG2itiwITW2soKJWE2LGl/28cLXXI +U9DlPPhQ7uHNnTjc3v8CfSWhU7C4wW1W5gzC6RdgDS/zUWx0AKQuWgBtOW1VGp7b5 JbHEWmola2E6NrjmVNMdZ+MR5+b67mB2A+KLvZ1E= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 30AB88B940; Fri, 10 May 2019 11:24:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 6vEArAskASY9; Fri, 10 May 2019 11:24:49 +0200 (CEST) Received: from po16846vm.idsi0.si.c-s.fr (po15451.idsi0.si.c-s.fr [172.25.231.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 15F368B7E6; Fri, 10 May 2019 11:24:49 +0200 (CEST) Received: by po16846vm.idsi0.si.c-s.fr (Postfix, from userid 0) id DAAD2673B2; Fri, 10 May 2019 09:24:48 +0000 (UTC) Message-Id: From: Christophe Leroy Subject: [PATCH v2] powerpc: slightly improve cache helpers To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Segher Boessenkool Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Fri, 10 May 2019 09:24:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cache instructions (dcbz, dcbi, dcbf and dcbst) take two registers that are summed to obtain the target address. Using 'Z' constraint and '%y0' argument gives GCC the opportunity to use both registers instead of only one with the second being forced to 0. Suggested-by: Segher Boessenkool Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/cache.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/cache.h b/arch/powerpc/include/asm/cache.h index 40ea5b3781c6..df8e4c407366 100644 --- a/arch/powerpc/include/asm/cache.h +++ b/arch/powerpc/include/asm/cache.h @@ -85,22 +85,22 @@ extern void _set_L3CR(unsigned long); static inline void dcbz(void *addr) { - __asm__ __volatile__ ("dcbz 0, %0" : : "r"(addr) : "memory"); + __asm__ __volatile__ ("dcbz %y0" : : "Z"(*(u8 *)addr) : "memory"); } static inline void dcbi(void *addr) { - __asm__ __volatile__ ("dcbi 0, %0" : : "r"(addr) : "memory"); + __asm__ __volatile__ ("dcbi %y0" : : "Z"(*(u8 *)addr) : "memory"); } static inline void dcbf(void *addr) { - __asm__ __volatile__ ("dcbf 0, %0" : : "r"(addr) : "memory"); + __asm__ __volatile__ ("dcbf %y0" : : "Z"(*(u8 *)addr) : "memory"); } static inline void dcbst(void *addr) { - __asm__ __volatile__ ("dcbst 0, %0" : : "r"(addr) : "memory"); + __asm__ __volatile__ ("dcbst %y0" : : "Z"(*(u8 *)addr) : "memory"); } #endif /* !__ASSEMBLY__ */ #endif /* __KERNEL__ */ -- 2.13.3