Date: Thu, 10 Nov 2005 17:14:46 +0100
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@osdl.org>,
       Linus Torvalds <torvalds@osdl.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Virtualization Mailing List <virtualization@lists.osdl.org>,
       "H. Peter Anvin" <hpa@zytor.com>,
       Zwane Mwaikambo <zwane@arm.linux.org.uk>,
       Martin Bligh <mbligh@mbligh.org>,
       Pratap Subrahmanyam <pratap@vmware.com>,
       Christopher Li <chrisl@vmware.com>,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 12/21] i386 Deprecate descriptor asm
Message-ID: <20051110161446.GA13204@snarc.org>
References: <200511080431.jA84Vdg5009909@zach-dev.vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200511080431.jA84Vdg5009909@zach-dev.vmware.com>
User-Agent: Mutt/1.5.9i
From: tab@snarc.org (Vincent Hanquez)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 660
Lines: 23

On Mon, Nov 07, 2005 at 08:31:39PM -0800, Zachary Amsden wrote:
> +struct desc_internal_struct {
> +	unsigned short	limit0;
> +	unsigned short	base0;
> +	unsigned char	base1;
> +	unsigned char	type;
> +	unsigned int	limit1 : 4;
> +	unsigned int	flags : 4;
> +	unsigned char	base2;
> +} __attribute__((packed));

just a minor nit,

wouldn't that be better to use u8 and u16 types here ? 

Cheers,
-- 
Vincent Hanquez
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/