Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751113AbVKJQUa (ORCPT ); Thu, 10 Nov 2005 11:20:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751117AbVKJQUa (ORCPT ); Thu, 10 Nov 2005 11:20:30 -0500 Received: from mail.suse.de ([195.135.220.2]:62691 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751113AbVKJQU3 (ORCPT ); Thu, 10 Nov 2005 11:20:29 -0500 From: Andreas Schwab To: linux-kernel@vger.kernel.org Subject: Re: Broken __get_unaligned from References: <20051110144847.GA28700@flint.arm.linux.org.uk> X-Yow: .. this must be what it's like to be a COLLEGE GRADUATE!! Date: Thu, 10 Nov 2005 17:20:27 +0100 In-Reply-To: <20051110144847.GA28700@flint.arm.linux.org.uk> (Russell King's message of "Thu, 10 Nov 2005 14:48:47 +0000") Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 27 Russell King writes: > On Thu, Nov 10, 2005 at 03:42:05PM +0100, Andreas Schwab wrote: >> __get_unaligned can't cope with const-qualified types: >> >> drivers/char/vc_screen.c: In function 'vcs_write': >> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val' >> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val' >> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val' >> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val' > > What if get_unaligned is used with a u64 / long long type (which it is)? Oops, I missed that, it needs a different approach. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/