Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2198064yba; Fri, 10 May 2019 07:46:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkx2cDl07SAUDlaXqzPWD+UfdrMu57labHls80gYozKd4Ge/B6l5w7OuTpW5xUK+S2bUIT X-Received: by 2002:a63:f710:: with SMTP id x16mr461493pgh.216.1557499573203; Fri, 10 May 2019 07:46:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557499573; cv=none; d=google.com; s=arc-20160816; b=evStDgXeI8Y67kJPP2AWelmmsB+GABEVOIpqm1fnbs2u2a3F4WRUWl5taBJw+4UwDj yI0ETwD6Y8fwwQjoYw1V+HdHVk0f+ywdDETaDAUIEqOzQOo8CwwnYjmOe2txkNKNQtAU SpWKGGJTc4sGaYH1ocrMJr/ffKRg2PEU1hjR44hoK9ik5RSJ7CZ9cYR2l1Bxv7hcjGrm aZXHGpboUE1xTAym6CUu1TaOIst+I3IQO3JSw5NL5zwcwb3AwIiYLeVLR5EU0cHFnp1i wr9J+5WjTCXLnBreSJ+d23WG3wqyubsbJtBCvd528dsdEK4ZapQM7f6fMiIW71BjpRoK QGDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VU+PRSz5p+wmkulkZ9L90xGJUZSvKYAjzq70nWVfyAk=; b=mX7CDYQK/X9FTHn2EQ1Vz0Ts1DdVE+GdL3BlzDczjpyRI2P5GIsvEle/Da7ZHlniQf cMRpTytLo2xKVJJ4R0AIuyFMDhNYARqLHxj7F7YUKDw4OHb7oiP55UXaDlBpQAJh48ch /lpEa8y+6udQCexiGkTg497ab3Q6WvmVSW2P9p2gQhUkBevM3noRMu4wnGK6TOI6ty34 hcPXO7oqRxCOfKgOGeaU92cKWgK+g7/nuYQxft6/rtDQ4CL0f+x/JHzfl7SW778UV2Zt VWAE7+l8kDGLt+I1ifjH+IqYMOy7bpbsH1/yRJskRdG2Hbj0sjcjZJpjChh6vROqAjiA d1GA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q22si7123767pll.184.2019.05.10.07.45.55; Fri, 10 May 2019 07:46:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727847AbfEJN6E (ORCPT + 99 others); Fri, 10 May 2019 09:58:04 -0400 Received: from mga06.intel.com ([134.134.136.31]:18693 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727425AbfEJN6D (ORCPT ); Fri, 10 May 2019 09:58:03 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 06:58:03 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga001.jf.intel.com with ESMTP; 10 May 2019 06:58:02 -0700 Date: Fri, 10 May 2019 07:52:34 -0600 From: Keith Busch To: "Rafael J. Wysocki" Cc: Kai-Heng Feng , Mario Limonciello , Christoph Hellwig , Jens Axboe , Sagi Grimberg , Linux PM , "Wysocki, Rafael J" , Linux Kernel Mailing List , linux-nvme , "Busch, Keith" Subject: Re: [PATCH] nvme-pci: Use non-operational power state instead of D3 on Suspend-to-Idle Message-ID: <20190510135234.GF9675@localhost.localdomain> References: <225CF4F7-C8E1-4C66-B362-97E84596A54E@canonical.com> <20190509103142.GA19550@lst.de> <31b7d7959bf94c15a04bab0ced518444@AUSX13MPC101.AMER.DELL.COM> <20190509192807.GB9675@localhost.localdomain> <7a002851c435481593f8629ec9193e40@AUSX13MPC101.AMER.DELL.COM> <20190509215409.GD9675@localhost.localdomain> <495d76c66aec41a8bfbbf527820f8eb9@AUSX13MPC101.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 01:23:11AM -0700, Rafael J. Wysocki wrote: > On Fri, May 10, 2019 at 8:08 AM Kai-Heng Feng > > I tested the patch from Keith and it has two issues just as simply skipping > > nvme_dev_disable(): > > 1) It consumes more power in S2I > > 2) System freeze after resume > > Well, the Keith's patch doesn't prevent pci_pm_suspend_noirq() from > asking for D3 and both of the symptoms above may be consequences of > that in principle. Right, I'll fix up the kernel's PCI D3 control and resend for consideration.