Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2415313yba; Fri, 10 May 2019 11:05:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdS/jVg5qgsbK7DiIDw8cTmBPW1Strg5VLjxx/SDX/U8DB6l1Gqtxb9mTY2KyTE7uzqn4Q X-Received: by 2002:a63:f146:: with SMTP id o6mr15645453pgk.179.1557511535550; Fri, 10 May 2019 11:05:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557511535; cv=none; d=google.com; s=arc-20160816; b=w9oyVnPIvnU9poJ4vxZiAyh4WCRE5AbZS+ToNdJUgk6GGDcUGdT+q8yYkbD60aW/Xw FQRnRYVJec1XYdcATrUojDbnogrjM8OEEq2bA6dUnFeBaMm28lnIpT3jy4ZdZ3d03W3o zw66l3QHfXIyvKZbVxie5Pi5okh19Q7C+YUka+Ueez6WfzdlqD/m1i66Nq6t7xndDPSD fCA+zfyL+T4BqfJiK+uUke3dydIcW2hwwN496M7T/bh4q3lE9XiuZk9MmN4SszBx52CZ +mQoraRKRbWWpgHxgbqVh6Qnfx1cr8zlcdVD6ViNR4dws5GpvZ4bcDQB/eOMRh5/HayR aeAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0/3h1kMbNsFz/9Ja/3wNgp3lXv+K0KmnTBsVELfUR00=; b=gWVheClIGIeeE1wlYKJQyS9nH8YMV95j5zaTOLoHz2bzKzin/NAtTGLodCQRjUCI6u vm1Ubizwuf5MDLiB1OwAS8uiajrkraw7qVj7O07Z2hQurFRUU74flsRSIbDravFeV8u/ cm8OqKnLnq+KcyimOIrPCfIrp6zAI6RzY8K2OAfWiRhy3jQbibnm6HNx0QJD63gQWXcA X20VM7khGALbBoJXCZph+qTOQmeuyifauV6ZpM2lCA86Bxz3aH0z+PfxjLYZwxmatkRD FZ/gz7GopeCHu27W07jUgR6RlDMi3FBVWw3qhGC22vvw0wq3DrJ2q8gZ7aFaouImOSBj jQMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XUIUURZH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si8662078pgs.254.2019.05.10.11.05.19; Fri, 10 May 2019 11:05:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XUIUURZH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728007AbfEJSCK (ORCPT + 99 others); Fri, 10 May 2019 14:02:10 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39964 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727937AbfEJSB4 (ORCPT ); Fri, 10 May 2019 14:01:56 -0400 Received: by mail-pf1-f195.google.com with SMTP id u17so3617680pfn.7 for ; Fri, 10 May 2019 11:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0/3h1kMbNsFz/9Ja/3wNgp3lXv+K0KmnTBsVELfUR00=; b=XUIUURZH2RPIOEBY4ZT6CGvC2zPBAvX/JHtr/s0Oqb95aYCoTcPMJKyzVxcsnTACkt Eg1REMjQkhu+sjucVhtTTSeEh+WDjzJ038G7pv6W4t0mjNa6ECQm6HnYxzxUCnbBgC11 4y/xA3G9ozFmevuQVAaHSFWolEd47L+NZNzG4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0/3h1kMbNsFz/9Ja/3wNgp3lXv+K0KmnTBsVELfUR00=; b=tph+CXafzL7rbtUrsODTroV0i1TLvT/f2EXNMuTNy0iD9QW47tPnfKkiBUkNpaGRpk NKWefl2PJYbgJEuaNursmnVJizIvgrtAtqm1xc9At9ZSgEHA210cAfIkhbwMNCPFNXZ6 HJGNnkFf4vyKvKlHvrZZqb67m7vsbnCv8afBVgq1moTD8YcU6AX/OVnW4F81Rz653nqt ncYkmSOoh7zGW6MyjCAH6Xevc9xqg/DnmlYT3ACZ1GGwAYZZpAL1Ep1WdXsC4dWq/MgR 83z98OfeQygolGWCMWbaCYoPCMyPjCGiQD9vkrHMm98WVp7YyCSNrDbu4nfnXyr52AH4 pNNw== X-Gm-Message-State: APjAAAW4JYmo2xHHGC0JcLBDWlf7kmUSwS6hq/w5AX+6NNJpebGKX6ko YnKsIf9kdVQOxdMxb2PKjJX1Ng== X-Received: by 2002:a62:2b4e:: with SMTP id r75mr16139959pfr.131.1557511316262; Fri, 10 May 2019 11:01:56 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id s19sm7556740pfe.74.2019.05.10.11.01.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 May 2019 11:01:55 -0700 (PDT) From: Stephen Boyd To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Wei-Ning Huang , Julius Werner , Brian Norris , Samuel Holland , Guenter Roeck Subject: [PATCH 3/5] firmware: google: memconsole: Drop __iomem on memremap memory Date: Fri, 10 May 2019 11:01:49 -0700 Message-Id: <20190510180151.115254-4-swboyd@chromium.org> X-Mailer: git-send-email 2.21.0.1020.gf2820cf01a-goog In-Reply-To: <20190510180151.115254-1-swboyd@chromium.org> References: <20190510180151.115254-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org memremap() doesn't return __iomem marked memory, so drop the marking here. This makes static analysis tools like sparse happy again. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Cc: Guenter Roeck Signed-off-by: Stephen Boyd --- drivers/firmware/google/memconsole-coreboot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/google/memconsole-coreboot.c b/drivers/firmware/google/memconsole-coreboot.c index 0b29b27b86f5..ab0fe93b88ad 100644 --- a/drivers/firmware/google/memconsole-coreboot.c +++ b/drivers/firmware/google/memconsole-coreboot.c @@ -34,7 +34,7 @@ struct cbmem_cons { #define CURSOR_MASK ((1 << 28) - 1) #define OVERFLOW (1 << 31) -static struct cbmem_cons __iomem *cbmem_console; +static struct cbmem_cons *cbmem_console; static u32 cbmem_console_size; /* @@ -75,7 +75,7 @@ static ssize_t memconsole_coreboot_read(char *buf, loff_t pos, size_t count) static int memconsole_probe(struct coreboot_device *dev) { - struct cbmem_cons __iomem *tmp_cbmc; + struct cbmem_cons *tmp_cbmc; tmp_cbmc = memremap(dev->cbmem_ref.cbmem_addr, sizeof(*tmp_cbmc), MEMREMAP_WB); -- Sent by a computer through tubes