Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2435683yba; Fri, 10 May 2019 11:27:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqy/U4J2YbFVrmKdP5M2HndgXiGFddKeDPoiWztei4HO5OPZ8VXkWwdKFIa03pTY0BjPs785 X-Received: by 2002:a17:902:e287:: with SMTP id cf7mr15141821plb.217.1557512877091; Fri, 10 May 2019 11:27:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557512877; cv=none; d=google.com; s=arc-20160816; b=CIKhOcRDM7HFW24mgYXlvmogzJ2n8y8gFD8zBBzDoG8sim3/dc8UvHdsM+uHhXovNt GWKpFDuAQJFS6ch17Hl1+wBYMMovaFdyLp/6RE+DgiN/NXM9FcpAqTPrCsJ0z/wqXZs9 J0gNLOIzhRAN38xbqkorLhr/jhTDVjgztCU39+kxe/gOyRUzKYrCmZAcO7Z0UxCHLiXg HOWrbbaEUj1Yev+EhhvYELEnRzfC8PAwRYDafmd+IvAu+BG90o9aNK8MQXfo+ZOf3eai BuAt8cfOPBYsNxuC3GhZveErXwjP65ajKqe37PwpbPQUf7JYsUL5VkcpMiD1Q9mO+W61 Qftw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sKS5Fj/EEtSMbliwSHz31jl5UWhgaLLNKzcdv3HiOg8=; b=pMYkDZ0kWkfersX6YBZcCjix1XYMnlYUJJ2wRZCs/TvyyZtn+aZkMCKI3TYAYstgiu carVmm5fjxjK7FS1cQkhNZh3VWHzrbVCHYhG8OwCAJKOxV0rrdmYqKt9pwEmHtJREcE9 oTjg3cquX88DZlsMyDACdJ1peRQMvFr9xcZ0uqcIAWdnFiQxKQIdT3tEQbWo4WcfrQLT gBrN7fOv+wwlhQQkEBxfC4YXtHG4oWOi2kYuPGX4WDEMhuLWyZ5mq65fyeWVaUvqWMU3 yBIV0z5a7TF/nUfyQbju9oCIzA1vWaD/Zvp6erbfvFdjtyvA8cqfkKiiApXNFxvebsMz XDrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=AgdKZn6H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f65si2849654pfa.1.2019.05.10.11.27.40; Fri, 10 May 2019 11:27:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=AgdKZn6H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728034AbfEJSYB (ORCPT + 99 others); Fri, 10 May 2019 14:24:01 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:36160 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbfEJSYA (ORCPT ); Fri, 10 May 2019 14:24:00 -0400 Received: by mail-qt1-f196.google.com with SMTP id a17so6458341qth.3 for ; Fri, 10 May 2019 11:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sKS5Fj/EEtSMbliwSHz31jl5UWhgaLLNKzcdv3HiOg8=; b=AgdKZn6HYNv221xca0XVSBa2lJs6g9ZN/fDhC0UKtfgh86gPpSKySDa8EHoKdAkwXh OPUbb6rjj/0vZD/52ALcm64YAno6w2qlc0fZjC556wrBTip/57WnH2tDAaXD5ez1ykP8 6Bp99KZjroFrISTsE/THxKq7QrHKJtfroBoHARBah1Wh6GBCOWku+dgatZbZfhyf0eB0 AN5ykQG4Lvlbb9jLvV1MuBig9RfA6zoMDp19p9oQcsaMcNuI8AQdk0XWpINbpniDzEs0 wsXTfIJ2mhbB3kKPHj+HwVBWOY/vqx1LhxJRZhVqxJ7lb3HYOLWt381D0k7h8ebVtWZ9 EfFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sKS5Fj/EEtSMbliwSHz31jl5UWhgaLLNKzcdv3HiOg8=; b=fHGhdvlTGSslAwr/yvykcFOEszIfaT7e8Go/E272ZjlwiyfUtzKYwuthDvmQPyMI4q tALrge+xsgKDNO50HR6OOfahMxDIOoJu9I8Koe17Km6qPNliJGhjU5ImckXggQcuClCv eE36xnRo0MGNwFGGNv+7wFE7w+XRxH9Q5Z0Ex1tmWMQbEDNhOgNS7TsE3YvxWqudImoy 7o9bT8MgG8cYblbT1JmmoK4HrTePw+ugX+guvENb+RZjyurJ0mQmlKVSzU25OMee1zW8 V8zT5JGtrXx14GEX9QwLX0fQQGPf/4W5vVQsjtG+pcEmwz81SaZBF0IZ+tj+dnnip9sr WDfw== X-Gm-Message-State: APjAAAVDnmEIQ26bFSJgxJ1pGJB6O3aCsKC1eEVdXm2weomDPiO2zu9+ atMEELZeJcvU8L2caaVUKUvkqg== X-Received: by 2002:a0c:b99c:: with SMTP id v28mr10440432qvf.10.1557512639945; Fri, 10 May 2019 11:23:59 -0700 (PDT) Received: from localhost (pool-108-27-252-85.nycmny.fios.verizon.net. [108.27.252.85]) by smtp.gmail.com with ESMTPSA id x7sm3026823qkc.22.2019.05.10.11.23.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 May 2019 11:23:59 -0700 (PDT) Date: Fri, 10 May 2019 14:23:58 -0400 From: Johannes Weiner To: Dan Schatzberg Cc: Tejun Heo , Li Zefan , Ingo Molnar , Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] psi: Expose pressure metrics on root cgroup Message-ID: <20190510182358.GA14027@cmpxchg.org> References: <20190510174938.3361741-1-dschatzberg@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190510174938.3361741-1-dschatzberg@fb.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 10:49:34AM -0700, Dan Schatzberg wrote: > Pressure metrics are already recorded and exposed in procfs for the > entire system, but any tool which monitors cgroup pressure has to > special case the root cgroup to read from procfs. This patch exposes > the already recorded pressure metrics on the root cgroup. > > Signed-off-by: Dan Schatzberg Looks good to me, thanks Dan! Acked-by: Johannes Weiner