Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 May 2019 13:28:00 -0700 (PDT)
Message-Id: <20190510.132800.1971158293891484440.davem@davemloft.net>
To:     hofrat@osadl.org
Cc:     aneela@codeaurora.org, gregkh@linuxfoundation.org,
        anshuman.khandual@arm.com, david@redhat.com, arnd@arndb.de,
        johannes.berg@intel.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: qrtr: use protocol endiannes variable
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1557450533-9321-1-git-send-email-hofrat@osadl.org>
References: <1557450533-9321-1-git-send-email-hofrat@osadl.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Nicholas Mc Guire <hofrat@osadl.org>
Date: Fri, 10 May 2019 03:08:53 +0200

> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index dd0e97f..c90edaa 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -733,7 +733,8 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
>  	struct qrtr_node *node;
>  	struct sk_buff *skb;
>  	size_t plen;
> -	u32 type = QRTR_TYPE_DATA;
> +	u32 type = 0;
> +	__le32 qrtr_type = cpu_to_le32(QRTR_TYPE_DATA);
>  	int rc;

Please try to preserve as much of the reverse chrimstas tree here rather
than making it worse.

Thank you.