Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2578227yba; Fri, 10 May 2019 14:19:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSUyOTqe/xlxMb/1sX9LWs53BBXJVQJ9OKdpYpYEbuIJDlpuUGJZD9ody6XfIgyh4x+qav X-Received: by 2002:a63:fc55:: with SMTP id r21mr16247184pgk.441.1557523167072; Fri, 10 May 2019 14:19:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557523167; cv=none; d=google.com; s=arc-20160816; b=l74SQtjtubiVeHyKxgN155QLhCcrpfYXmYlWPTlQ+/f0uMVk7GMwTupD/9Fqra/VyX 2DaXLopJZmYWQPjXV/z0PrUyb27Dq4yd1MysHxYeMXzqdd3IjfvvczZpqQS0x0O+8kRS cm1l9J2hq7QypVKji2SpdITbgW1laZ/MtH+/E1cfI7H63Y7Tac4IAVgAMBWXONsyAEgm ZDVjpmkLeyvHKb5qPCD376FqmmlOxnTGkMPCfllUd45oDBLZXPWJ7QDIt95ydt4pOlBT eqpWBU1Qo1DpiZQqAaXtge1FIAaOMcSlNiT3bcq6uAn+XXxErbWJA7jX3NMUdZ9uCN3x 5g5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=V7NF/px8KxbdQntgKg6KraTQDbTpqs5ztHgPNp3qHxI=; b=GqLJ1V8SM/SFOTJBZJlZL73ZLw+1D72xqX3pZrKB++nz+dXiY37iCNCV5oO60KIXX7 Vo46GDLhiQOUhmdXUGX3eglG5JoApOHx21F54HeGd1TzDQSW32cG93HM9gJX3jF9yjNE rIn2iXLyZ5qvBSxGfwtYk3mt+LZLB/K10kFnTBDZYU6Q8xdSu6pW4ECepR36kxbKVr+L ZSilwyBoP65KmofVSqLbikfUkjYlPOxI9/Adik+c87XPr7L60kAH0jsa/cgGkNwUDGT9 5sEjIcEtJRledvr7DOfg2jy5CtORlLFwM9NQwy5MjYDB5fdzVW47eJ985GHq9E97LpRA ugVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YNxRIaYg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si8234453pls.395.2019.05.10.14.19.11; Fri, 10 May 2019 14:19:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YNxRIaYg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728032AbfEJVRB (ORCPT + 99 others); Fri, 10 May 2019 17:17:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:59102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727767AbfEJVRB (ORCPT ); Fri, 10 May 2019 17:17:01 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9735520896; Fri, 10 May 2019 21:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557523020; bh=WrSi5jHV6SOltHTRjAOARni7OmFLSEe0K6ep9p6h53s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YNxRIaYgHUo1dWlD85ZFCIL5YSk3Cha+eYCoGs5AgoCUDVCBzesDOqhW3oY60AP1O ARNXJwykVG2EbSSoceQDX3qlwp0wm3LhS+fgUA3xdDskZL1P1OY/wToCjOfz7XYwk9 n4L/v528+OlY1WjeYvlQLjXiYKlFWEp6Kr2gzaJs= Date: Fri, 10 May 2019 14:16:59 -0700 From: Andrew Morton To: Dan Schatzberg Cc: Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Peter Zijlstra , , Subject: Re: [PATCH] psi: Expose pressure metrics on root cgroup Message-Id: <20190510141659.08f58679c2eb3d321092dc23@linux-foundation.org> In-Reply-To: <20190510174938.3361741-1-dschatzberg@fb.com> References: <20190510174938.3361741-1-dschatzberg@fb.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 May 2019 10:49:34 -0700 Dan Schatzberg wrote: > Pressure metrics are already recorded and exposed in procfs for the > entire system, but any tool which monitors cgroup pressure has to > special case the root cgroup to read from procfs. This patch exposes > the already recorded pressure metrics on the root cgroup. > Documentation/admin-guide/cgroup-v2.rst says "A read-only nested-key file which exists on non-root cgroups". Documentation/accounting/psi.txt could do woth some clarification as well.