Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 May 2019 14:46:22 -0700
From:   Benson Leung <bleung@google.com>
To:     Evan Green <evgreen@chromium.org>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Stephen Boyd <swboyd@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_spi: Always add of_match_table
Message-ID: <20190510214622.GA63153@google.com>
References: <20190509181750.134960-1-evgreen@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD"
Content-Disposition: inline
In-Reply-To: <20190509181750.134960-1-evgreen@chromium.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--HlL+5n6rz5pIUxbD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Evan,

On Thu, May 09, 2019 at 11:17:50AM -0700, Evan Green wrote:
> The Chrome OS EC driver attaches to devices using the of_match_table
> even when ACPI is the underlying firmware. It does this using the
> magic PRP0001 ACPI HID, which tells ACPI to go find an OF compatible
> string under the hood and match on that.
>=20
> The cros_ec_spi driver needs to provide the of_match_table regardless
> of whether CONFIG_OF is enabled or not, since the table is used by
> ACPI for PRP0001 devices.
>=20
> Signed-off-by: Evan Green <evgreen@chromium.org>

Looks good to me.
Reviewed-by: Benson Leung <bleung@chromium.org>

I'll leave this to Enric to merge to our for-next.

Thanks,
Benson

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--HlL+5n6rz5pIUxbD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlzV8SsACgkQHwn1ewov
5lgtdxAAixyvYNuxuXb3R0XUwoZr4OW17jwYk1zu4/Y4tsaMWY0ZS0RyInFygScC
+70a6qG+DNtmPaHWOajFIlFjaGPpteaIizPUPzglGgqF6vy+901oenxEtqapcq+U
c7kq0PZaRpRH789s8CYomzz7zMYxy+58lrBgGki+0tlRz44NMEKPR4N+wTo9zF0h
Omj0cjKfiCUHsKAn/pe+oye+a9Xqj+CyyPByAobY0haTrDPtwgNrn5ma0SXxQDPz
VlelhEMJxsVsxHJ394zhGNRYmiHMbG+PHbOMXCtndf9qO7lERa9PlvQObvjG9TSj
56vf4fib3Mx3Oc32yLtBxDKvoDglpSO/WV6Yc0vsGTPLblgVU/Zi1oYchvT0mJsD
CwlsFoLB5uWKpLOvwxw5VXY4WdlAuyHT2ja6nshIJBJgagEMzMllPlikHWE5RmFu
v83EzzUS6Tzzs2cURsTRkPS6nV56EUANWJ8xI7rFzi/VVBCQD9FV1RrPXwIqIj0i
7rThUyaP0tPjN0bX//2HqlLN7Nd0z437NsE9eSHi3wv0wQFyoEaI3+SA9fKod+Ww
R416YDmZEeLNqPup1DOTQRyLxF7LkEBzhT2ptDInH+shOKADeJZRrKZ/+twOZz3C
nSeiW4QnjpKLqV6C2yUp3kS2yX3+I+iEXePRNLr9A+lr0Ho6JSQ=
=rt78
-----END PGP SIGNATURE-----

--HlL+5n6rz5pIUxbD--