Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3184586yba; Sat, 11 May 2019 05:41:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqz9arB3nImCbuLcvZzk9Y73HtPOPlJoRRq6183jAiqbwKSCbOFm8O0FiJZmBQWg3oCmeYB/ X-Received: by 2002:a17:902:82ca:: with SMTP id u10mr7687960plz.231.1557578467703; Sat, 11 May 2019 05:41:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557578467; cv=none; d=google.com; s=arc-20160816; b=xB6QARE5z7vR0oPOIkb5wJL47IdNBfMDGIm6rekPaxu4C2DzIdROAMB4+qi0b9yg+z At4663dl3zUftqh0pPO9g6P/w1U4FIvYUlVZcanJYb0qpXmYUd8htsiYWJXe635NltXg uiBV2oKPvfyVAqBu3Vq1VhIlTdLQDdFlmIPudauGU04z6p0cHnK36Ae6UCfXpdvNsXr4 EVJDK5V/+0SqlciNvAJgwEpympE+h+h8R0Jwrm2gq67OJnoxHrQzTQRuBUU40+n2ijy6 +suGKyAUAVkpg946vkSvHg+D25pVoMFrAZ1RumedxpLg/T9l8FdqxxuY3eViSbaPiOpO s9rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=z71J1bU8XNXgvTKKX4ur9AflvwyiZW8Xbhpg4+Cu1dU=; b=FAJqG2tWk2h6kKx8dJh9nr1KUrHLwiZ+04x4/wNWtD2M8ne7OncjvoOvR+YC4hWtoR mOVZ/GAwOpMiwfvpdFYeGxU9GILx+psX7Z0CQU6AHBxGoBCHu/UdmM2ZexyLgClRv9qu /AgMSPHKd3QekzlE3R13OZmkjDNA7+zmdc4k5LyzBuxdQzvzvj3J0L2TI1CVxpxd+r9Y uw4dWUl5UV1iBExtkBhNxMqIC3Cudacu6PLhXeHmHT5n9cPV4LORdbTS4szQYIdZN9P1 MzklfM2psnRhTlyYRFGkXeTy0N9j/jSu4kmp9wINpLUwTzl0zpOcJNJ9UPrfjmo/iZu6 vQww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn14si10155803plb.7.2019.05.11.05.40.51; Sat, 11 May 2019 05:41:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728580AbfEKMj5 (ORCPT + 99 others); Sat, 11 May 2019 08:39:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:54576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfEKMj5 (ORCPT ); Sat, 11 May 2019 08:39:57 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D65D3208C0; Sat, 11 May 2019 12:39:55 +0000 (UTC) Date: Sat, 11 May 2019 08:39:54 -0400 From: Steven Rostedt To: LKML Cc: Peter Zijlstra , Linus Torvalds , Jiri Kosina , Josh Poimboeuf , Andy Lutomirski , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org Subject: [PATCH] x86: Hide the int3_emulate_call/jmp functions from UML Message-ID: <20190511083954.23a60052@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Steven Rostedt (VMware)" User Mode Linux does not have access to the ip or sp fields of the pt_regs, and accessing them causes UML to fail to build. Hide the int3_emulate_jmp() and int3_emulate_call() instructions from UML, as it doesn't need them anyway. Reported-by: kbuild test robot Signed-off-by: Steven Rostedt (VMware) --- [ I added this to my queue to test too ] arch/x86/include/asm/text-patching.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/text-patching.h b/arch/x86/include/asm/text-patching.h index 05861cc08787..0bbb07eaed6b 100644 --- a/arch/x86/include/asm/text-patching.h +++ b/arch/x86/include/asm/text-patching.h @@ -39,6 +39,7 @@ extern int poke_int3_handler(struct pt_regs *regs); extern void *text_poke_bp(void *addr, const void *opcode, size_t len, void *handler); extern int after_bootmem; +#ifndef CONFIG_UML_X86 static inline void int3_emulate_jmp(struct pt_regs *regs, unsigned long ip) { regs->ip = ip; @@ -65,6 +66,7 @@ static inline void int3_emulate_call(struct pt_regs *regs, unsigned long func) int3_emulate_push(regs, regs->ip - INT3_INSN_SIZE + CALL_INSN_SIZE); int3_emulate_jmp(regs, func); } -#endif +#endif /* CONFIG_X86_64 */ +#endif /* !CONFIG_UML_X86 */ #endif /* _ASM_X86_TEXT_PATCHING_H */ -- 2.20.1