Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3228733yba; Sat, 11 May 2019 06:32:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqweL0f8v0EaBJG7j51lm9KM36lizQzMYmchrQFZPrm0WFt6IOY7ycjnSLERyj2fnzdOpXTU X-Received: by 2002:a62:6f87:: with SMTP id k129mr21868714pfc.53.1557581577520; Sat, 11 May 2019 06:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557581577; cv=none; d=google.com; s=arc-20160816; b=QQdHNrEShhtXF5nuOtEd39m8JsCdxxbfatV8p0cxlPJJNHWnGSn5I5UETi90hBvsHV qVYljYDdnJZu/6xIdIY2JNJ9E7P0u3KiCFtumT2MXX2+0USA+tkwaGvRUtsvrhieEsGU EXEu9xngycKCzRYX2Xd2FONYddKw4HekInGmuLpwD8egZvVrbwNCHm2pXhVExCLjsxfB y721LcHqoNFEE6P6WfjI9HBfGOsv7E+plquQe4ErrTJHqYGL/9Twv5aflIQpDw9r4TCg l+WbKnM2XN/i2ehjE9nm7dT5fgau44ROq8pC1T/pRIxMu3feDYugd7VzRErZPM9f1J+j Dj3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=s/AZSOJdvUNU5yPgVGE8CutgVSk3rVEECA+FUX1RXDw=; b=RfJZgt8VyQCAiVXhlRFHbM0MsuTkIQwI2SRFlavwVSfCby0BYTrjeU5xaAsRJAYa2x +l8SPZrM7H06LQkQbookYRa16vOBimPLuMH+10Nc58WhxPW7rIh8XjQmo6SC35PjYzPu 1us1e26kvpaGGKCnfZ8jQGA/qLfrI44XgfW9lXXL2etjeVqjbXqAXdwiGOY+R8ZB5vf7 DXyhJN/0HBkpkps4fy6F8XtzK3i1ht9kFyEKlgBIydYyZlTIfI3zHFz9X4VCY+S2vM0a 4Q3sguPzckibe4xdli04pl+AvQaOJ0gXwcSOv6F9kJN9iqzZSEOX2T9fE4uNSUvYqBZ7 eGnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=Pd1sGj7G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si10620487pgs.343.2019.05.11.06.32.40; Sat, 11 May 2019 06:32:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=Pd1sGj7G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728610AbfEKNbk (ORCPT + 99 others); Sat, 11 May 2019 09:31:40 -0400 Received: from nbd.name ([46.4.11.11]:55338 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbfEKNbk (ORCPT ); Sat, 11 May 2019 09:31:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s/AZSOJdvUNU5yPgVGE8CutgVSk3rVEECA+FUX1RXDw=; b=Pd1sGj7GJ++06en9Qla/DwHFxy jLRvRo7YD1PLcTj+xmf05M9cwjo+4FcZ8NBQiPoKTy329QTs17V3Z0FKNcZqtO6LkJxqD53I5GqPI 9rE89PBKHg/+YTcurS0k0iwItGOB+DHzRpNf0v4lvL2d8/J8yisH54Pez4SM6mvY8Qto=; Received: from p54ae9c89.dip0.t-ipconnect.de ([84.174.156.137] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hPS6B-00028f-17; Sat, 11 May 2019 15:31:35 +0200 Subject: Re: [PATCH][next] mt76: fix less than zero check on a u8 variable To: Colin King , Roy Luo , Kalle Valo , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190505213135.3895-1-colin.king@canonical.com> From: Felix Fietkau Openpgp: preference=signencrypt Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= mQGiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwbQcRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPohgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQuQINBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabiEkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: Date: Sat, 11 May 2019 15:31:34 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190505213135.3895-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-05-05 23:31, Colin King wrote: > From: Colin Ian King > > The signed return from the call to get_omac_idx is being assigned to the > u8 variable mac_idx and then checked for a negative error condition > which is always going to be false. Fix this by assigning the return to > the int variable ret and checking this instead. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets") > Signed-off-by: Colin Ian King Already fixed by a similar patch by Dan Carpenter. - Felix