Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vicente Bergas <vicencb@gmail.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Florian Fainelli <f.fainelli@gmail.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: net: phy: realtek: regression, kernel null pointer dereference
Date:   Sat, 11 May 2019 17:16:35 +0200
MIME-Version: 1.0
Message-ID: <fce7258a-b033-4d39-8ad1-4e56917166c5@gmail.com>
In-Reply-To: <20190511150819.GF4889@lunn.ch>
References: <16f75ff4-e3e3-4d96-b084-e772e3ce1c2b@gmail.com>
 <742a2235-4571-aa7d-af90-14c708205c6f@gmail.com>
 <11446b0b-c8a4-4e5f-bfa0-0892b500f467@gmail.com>
 <20190511150819.GF4889@lunn.ch>
User-Agent: Trojita
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Saturday, May 11, 2019 5:08:19 PM CEST, Andrew Lunn wrote:
> On Sat, May 11, 2019 at 04:46:40PM +0200, Vicente Bergas wrote:
>> On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote:
>>> On 10.05.2019 17:05, Vicente Bergas wrote:
>>>> Hello,
>>>> there is a regression on linux v5.1-9573-gb970afcfcabd with=20
>>>> a kernel null
>>>> pointer dereference.
>>>> The issue is the commit f81dadbcf7fd067baf184b63c179fc392bdb226e
>>>> net: phy: realtek: Add rtl8211e rx/tx delays config ...
>>> The page operation callbacks are missing in the RTL8211E driver.
>>> I just submitted a fix adding these callbacks to few Realtek PHY drivers
>>> including RTl8211E. This should fix the issue.
>>=20
>> Hello Heiner,
>> just tried your patch and indeed the NPE is gone. But still no network...
>> The MAC <-> PHY link was working before, so, maybe the rgmii=20
>> delays are not
>> correctly configured.
>
> Hi Vicente
>
> What phy-mode do you have in device tree? Have you tried the others?
>
> rmgii
> rmgii-id
> rmgii-rxid
> rmgii-txid
>
> =09Andrew

Hi Andrew,
it is configured as in the vanilla kernel:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/=
arm64/boot/dts/rockchip/rk3399-sapphire.dtsi#n191
,that is,
phy-mode =3D "rgmii";
There are also these configuration items:
tx_delay =3D <0x28>;
rx_delay =3D <0x11>;

Instead of going the trial-and-error way, please, can you suggest a
probably good configuration?

Thanks,
  Vicen=C3=A7.