Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3377561yba; Sat, 11 May 2019 09:19:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEpGRzvrRjooYsMGZFL/lszOP64FAFeLLMHBbbjXnVbQlnLo84zSIpG4uS8yYB4y8rLKbP X-Received: by 2002:aa7:9a99:: with SMTP id w25mr22613586pfi.249.1557591577905; Sat, 11 May 2019 09:19:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557591577; cv=none; d=google.com; s=arc-20160816; b=FqlgT/zNLMAkmRG/HF0j+1PxZnQJCiIM6lVghIvtVC0WIrAiRzxn+kD8Ys2kod1n75 f2pPc9tBGcqujzdp+4nhQqEGRFFpih50n+Qxn95ICMKnsF7emMgxP2zyf9P+4dPuzxko t2ymiNTbvnLoNW3R1EevIHHwGMHWYZgd2+XjG1yUi2vZmUS1grf4cpxLApe9ZWecTdGn GbAiAwDxr1oM7SKM+A144YZXlRCsRhmHoH80IVb17OJrCVd49ohznVk0yUrc7wkte7IW Pzeh+PuBQA+eYH60z0i1faF8O1yWFAh5zbLnMLjyom2OimQORiDsAwu+fYIa2c2CCOHT /cqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Odh+YMUmXqxxn2pUwWEKZYqwhsM/e7BZh99KpQUKonM=; b=XdVrqaHSqa8+CFzPmZdda89mQqLvVQM/5c5Y1hCcMGGOf7khuibVe9eIur8FpWCFjE 4MezkVV+8j6bAkpXOK/QCkjXrYept6f/bVGIWepy35NnXSH4UmNrRO3cTJwkTUARi2UE WSBHEU5RnspaAdwrgd4Psw3XqoB/vQ/gJjwFEWQLWfj0q6vZ+UPntIc5CoBqr7qdhW6g 77q2+3UoDJ4pyutnBPLmGeW1EVL+6j0wdUCzaNdrmyL83AZEQKqC5Mrt3zRWqBO17sSf YDwMMcfiwIdev1suBRc2ZynS9cpXKOdT6fNq/FaJ6DMRfzfw+4thDkwq7XtMZ3r5CKMQ cbsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b="qLq/xi5V"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15si12484998pgu.218.2019.05.11.09.19.20; Sat, 11 May 2019 09:19:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b="qLq/xi5V"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726842AbfEKQRT (ORCPT + 99 others); Sat, 11 May 2019 12:17:19 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39190 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfEKQRT (ORCPT ); Sat, 11 May 2019 12:17:19 -0400 Received: by mail-pf1-f194.google.com with SMTP id z26so4853010pfg.6 for ; Sat, 11 May 2019 09:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Odh+YMUmXqxxn2pUwWEKZYqwhsM/e7BZh99KpQUKonM=; b=qLq/xi5VaOmk5QBHpCipGArPVi3NegYyBubZ0l23k5Meagl/axkdmV0pJLKMnaBK6x 719v6LAMXaMXcOXzRKnSMK9Cse4PTZxL4W79PAR6oqtFAKiPyR4GJfPIg8Xf7+4STwCO 7DzTlF98i4slQDIv6HVl4kUQlCuvXNgpq5WCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Odh+YMUmXqxxn2pUwWEKZYqwhsM/e7BZh99KpQUKonM=; b=i8jdwYd9p38w5t91biCbB/pRbbh97WHBGEJn9EWN6X3Dqg8K+aMr8m5Hkv+t3pebrV gF2c4xVIUSkduab6cuTncVJ87xObkDV33Q2WJRQ54OURcXFOBxCfE5oz55gX73bY1cjP QLjMPbJsopuIAo8t5y7vT2EZVHC4POH1aVEBk/twSPRw2KQHaVaeBdXPEaGPrWVvrHHc v+L22MQi5htCW7ifdLC1d1QHez+Djju1/974Whwvi7OhQhbd4h+gs92D/5Ft1FN+al6d GVuzPAUf4+JQczaCx87IPZPxyJiL3j2V+D+3wk7CRrQVv/jV4E5tGHo8CAgUTdNGmVmQ uOpA== X-Gm-Message-State: APjAAAWu+yhVoXsG2IcIjdwXggmubkp/BJ9WtfxwiFNqW+nHxMgNqpJX 1ZIboumJGjtsqnAfnW8ulQMv2Q== X-Received: by 2002:a65:62c4:: with SMTP id m4mr21634116pgv.308.1557591438309; Sat, 11 May 2019 09:17:18 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id z187sm12253685pfb.132.2019.05.11.09.17.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 May 2019 09:17:16 -0700 (PDT) Date: Sat, 11 May 2019 12:17:14 -0400 From: Joel Fernandes To: Greg Kroah-Hartman Cc: Masahiro Yamada , Linux Kernel Mailing List , Adrian Ratiu , Alexei Starovoitov , Andrew Morton , atish patra , bpf@vger.kernel.org, Brendan Gregg , Brendan Gregg , Daniel Colascione , Daniel Borkmann , Dan Williams , Dietmar Eggemann , duyuchao , Guenter Roeck , Jonathan Corbet , Karim Yaghmour , Kees Cook , "Cc: Android Kernel" , "open list:DOCUMENTATION" , "open list:KERNEL SELFTEST FRAMEWORK" , linux-trace-devel@vger.kernel.org, Manjo Raja Rao , Masami Hiramatsu , =?utf-8?Q?Micha=C5=82?= Gregorczyk , Michal Gregorczyk , Mohammad Husain , Olof Johansson , Qais Yousef , Randy Dunlap , Steven Rostedt , Shuah Khan , Srinivas Ramana , Tamir Carmeli , Yonghong Song Subject: Re: [PATCH 3/3] kheaders: Make it depend on sysfs Message-ID: <20190511161714.GA179270@google.com> References: <20190510210243.152808-1-joel@joelfernandes.org> <20190510210243.152808-4-joel@joelfernandes.org> <20190511060203.GA18650@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190511060203.GA18650@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 11, 2019 at 08:02:03AM +0200, Greg Kroah-Hartman wrote: > On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote: > > On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google) > > wrote: > > > > > > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it > > > depend on SYSFS as it makes no sense to enable this feature without it. > > > > > > And, it also makes no sense to break the feature by 1/3, > > then fix it by 3/3. > > > > > > Why don't you squash this? > > I agree, this belongs in patch 1/3. Fine with me. The reason I split it this way is I already had posted 1/3 recently for the driver tree [1], and I did not want to confuse Greg since he was in the process of picking it up [2]. Anyway, I can resend the series soon with 1/3 and 3/3 squashed unless anyone applying this is Ok with squashing it in their trees. thanks! [1] https://lore.kernel.org/patchwork/patch/1070005/ [2] https://lore.kernel.org/patchwork/patch/1070005/#1267273 thanks, - Joel