Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3437735yba; Sat, 11 May 2019 10:37:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKsLbJsscSEag69g9LLUiFrphuiztjAaVN0AWsRZnEp6QZXEF8ca6eJ24hfiA4KRqxv+QK X-Received: by 2002:a05:6a00:cc:: with SMTP id e12mr23548471pfj.207.1557596231395; Sat, 11 May 2019 10:37:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557596231; cv=none; d=google.com; s=arc-20160816; b=LM/0YtEd1Eezy3ahRzzGP/cZAKdmAhk1xZkSZRoxPZ9GJr020Di/kTFH92mxR4npZy 9b6jMga6fIin2ySOPIlYeVNu9P333nlA33fx/GCIdosM2FPM6pqcVFlV6x5ntpikF+X/ pvpgdZncxaGSYDuymQApYO0yxtW3n55XRsiHuCj1GReNsisHYW9FfA5/U27crI0M6wvj 6BgtqYsWnv0nMWi+WHyU5e9zx031Oo/sQHxW2WC6w3PMNPqCl3WlQE9E7u+ScVePHPM4 Sgf/6GNMHNIgSpQa7N/mfUciuz4LiSHKn8HTMYmNQ2b39he2mVvR2YEmglAs4CVy4FCt OhZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date; bh=Wkbjxm0k5ZGduKd3+apW+HSYSVLa/dUikd+vitAxFwY=; b=edEMkJget1V9NYjI4975r3IWh4K2XnMJcY3H33uA92wViiMJa1J4ADRnpb9IaILQsb J/vpXfUhTXoUahWC9kxRhDRVAaPJwhgW4xrKYr6BvVmOTQ83q9Tev8AKSgDy1o+TfakW 5xW7Vl4gb3xj9X/8Z1+H5oxYR7ngAH9AV877SE8/YeVKluClzfBniKuB9aJJe+PcjAzK EGmcnsT2/UmgDVu6YbHUAiyahZJM1UWB/vzl/fVTJNkASMOcOLPhUuTp1K+fvzBXX71l rnwNP8kHF3LJGx5/4DyEYC5stI0IF4QI4Dog6eyYFYU/Oa9wJ1mFHb4t5V815lY61jfF APzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si11753811plp.223.2019.05.11.10.36.55; Sat, 11 May 2019 10:37:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726302AbfEKRfq (ORCPT + 99 others); Sat, 11 May 2019 13:35:46 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:50198 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725879AbfEKRfp (ORCPT ); Sat, 11 May 2019 13:35:45 -0400 Received: from callcc.thunk.org (rrcs-67-53-55-100.west.biz.rr.com [67.53.55.100]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x4BHXkiw001051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 11 May 2019 13:33:50 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id DFD64420024; Sat, 11 May 2019 13:33:44 -0400 (EDT) Date: Sat, 11 May 2019 13:33:44 -0400 From: "Theodore Ts'o" To: Frank Rowand Cc: Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20190511173344.GA8507@mit.edu> Mail-Followup-To: Theodore Ts'o , Frank Rowand , Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com References: <20190509015856.GB7031@mit.edu> <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <80c72e64-2665-bd51-f78c-97f50f9a53ba@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80c72e64-2665-bd51-f78c-97f50f9a53ba@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 02:12:40PM -0700, Frank Rowand wrote: > However, the reply is incorrect. Kselftest in-kernel tests (which > is the context here) can be configured as built in instead of as > a module, and built in a UML kernel. The UML kernel can boot, > running the in-kernel tests before UML attempts to invoke the > init process. Um, Citation needed? I don't see any evidence for this in the kselftest documentation, nor do I see any evidence of this in the kselftest Makefiles. There exists test modules in the kernel that run before the init scripts run --- but that's not strictly speaking part of kselftests, and do not have any kind of infrastructure. As noted, the kselftests_harness header file fundamentally assumes that you are running test code in userspace. - Ted