Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Minwoo Im <minwoo.im.dev@gmail.com>
CC:     Sagi Grimberg <sagi@grimberg.me>,
        Mario Limonciello <Mario.Limonciello@dell.com>,
        linux-pm <linux-pm@vger.kernel.org>,
        Rafael Wysocki <rafael@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        Keith Busch <keith.busch@intel.com>,
        Kai Heng Feng <kai.heng.feng@canonical.com>,
        "hange-folder>?" <toggle-mailboxes@minwooim-desktop>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme/pci: Use host managed power state for suspend
Thread-Topic: [PATCH] nvme/pci: Use host managed power state for suspend
Thread-Index: AQHVB3hB+EEPM7nkIkW5pPdT52wd/g==
Date:   Sun, 12 May 2019 15:20:59 +0000
Message-ID: <SN6PR04MB45276B524D255F667A6BE29E860E0@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <20190510212937.11661-1-keith.busch@intel.com>
 <SN6PR04MB452735778FD952AA838E78C9860E0@SN6PR04MB4527.namprd04.prod.outlook.com>
 <20190512143056.GA7761@minwooim-desktop>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1222b068-5304-491a-b74d-08d6d6ed702a
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2019 15:20:59.4783
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB5422
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Disregard my comment.=0A=
=0A=
On 5/12/19 7:31 AM, Minwoo Im wrote:=0A=
>>> +	union nvme_result res;=0A=
>>> +	int ret;=0A=
>>> +=0A=
>>> +	if (!result)=0A=
>>> +		return -EINVAL;=0A=
>>> +=0A=
>>> +	memset(&c, 0, sizeof(c));=0A=
>>> +	c.features.opcode =3D nvme_admin_get_features;=0A=
>>> +	c.features.fid =3D cpu_to_le32(NVME_FEAT_POWER_MGMT);=0A=
>>> +=0A=
>>> +	ret =3D __nvme_submit_sync_cmd(ctrl->admin_q, &c, &res,=0A=
>>> +			NULL, 0, 0, NVME_QID_ANY, 0, 0, false);=0A=
>>> +	if (ret >=3D 0)=0A=
>>> +		*result =3D le32_to_cpu(res.u32);=0A=
>> May be add a check for result here in above if before deref pointer :-=
=0A=
>> 	if (ret >=3D 0 && result)=0A=
>>=0A=
> 'result' already has been checked in a few lines above.=0A=
>=0A=
> _______________________________________________=0A=
> Linux-nvme mailing list=0A=
> Linux-nvme@lists.infradead.org=0A=
> http://lists.infradead.org/mailman/listinfo/linux-nvme=0A=
>=0A=
=0A=