Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Cc:     linux-kernel@vger.kernel.org, tj@kernel.org, guro@fb.com,
        oleg@redhat.com, kernel-team@fb.com
Subject: Re: [REGRESSION] ptrace broken from "cgroup: cgroup v2 freezer" (76f969e)
In-Reply-To: <1557709124.798rxdb4l3.astroid@alex-desktop.none>
References: <1557709124.798rxdb4l3.astroid@alex-desktop.none>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1557712649_1872P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Sun, 12 May 2019 21:57:29 -0400
Message-ID: <1916.1557712649@turing-police>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--==_Exmh_1557712649_1872P
Content-Type: text/plain; charset=us-ascii

On Sun, 12 May 2019 21:20:12 -0400, "Alex Xu (Hello71)" said:

> I bisected this to 76f969e, "cgroup: cgroup v2 freezer". I reverted the
> entire patchset (reverting only that one caused a conflict), which
> resolved the issue. I skimmed the patch and came up with this
> workaround, which also resolves the issue. I am not at all clear on the
> technical workings of the patchset, but it seems to me like a process's
> frozen status is supposed to be "suspended" when a frozen process is
> ptraced, and "unsuspended" when ptracing ends. Therefore, it seems
> suspicious to always "enter frozen" whether or not the cgroup is
> actually frozen. It seems like the code should instead check if the
> cgroup is actually frozen, and if so, restore the frozen status.

Your analysis seems to be more or less correct, especially since your
one-line workaround patch makes things start working again.

> -               cgroup_enter_frozen();
> +               //cgroup_enter_frozen();

However, I'm sure this isn't a proper fix - it needs an if statement guarding
it (or a check inside the function).  If the kernel is ever in a state where it
*should* be frozen, and it doesn't freeze, things will misbehave.

One has to wonder how many things would be different if the ptrace()
system call wasn't such a steaming pile of dingo's kidneys....

--==_Exmh_1557712649_1872P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBXNjPCAdmEQWDXROgAQLxKA//dKkuY44x6J4v/bHl3puTl2AowsWUWKIJ
+wgMpolNqAUHSoVhRA613pSljTbADI7OL6ozUWtoZ6bzqEdSWptSldelCFeW//wq
6TBOmDMV5moZH7QikyjmIkO2CliDsGyPSxZzWfVMAtlGim6OClKqNxVsAPkOyLCi
qTVtvN1hMhCzISvDQGEEhUFKnRt5dmkDQrn1RDVAZba4rP9+rKK0X4X5O10dXGKJ
rYVXJlPoX/0GfbcnCj8aY1On0N8Lcq9QqQH7CCXrckiWK39SE1iCszPx2vORabws
nNIxZDa67tBuvyVIG0jk9He2t9bBycXMEocOR7viLtmxtxXJ3OmXZ0AS4cA+DvAr
Lbk4oqoTi6g3pI73CGm5C4t9ewSQB77G30N+uL4sHoEGwzBFA6Ry4hHlFqM7d05Z
LMDkMd3ffPDiJDpnzwblBlA2KS0TBHBDn2ZPw/3hiF+rOpxdaHokKiF8xSoKgfQa
RiJVuGpHJ6FDyekFVa9CKePyp24QRKkjFSLnCRmlar+R7Rxq0yNHc6NFv/CpR1pM
4V+AyQy3A/WxX1yhcHXEubZVrtafuRDCbL1lDQFHd/620Rhy5qxY6q+LB2pdtM5O
jPccNn/yM3bKZxpiwTmOgLGf8Iof5gb0vtOIJwcBK5D2kwuK9hXFvMOTElaIVHMh
4RdIO1/df8s=
=vj9r
-----END PGP SIGNATURE-----

--==_Exmh_1557712649_1872P--