Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4706764yba; Sun, 12 May 2019 20:29:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUfttShoZeEV0uNIlH8O3jQtLI74ylXZlUVE8W8k9oQgerNMpWUhLyNp6t0p59sgKtWtXa X-Received: by 2002:a62:1f1b:: with SMTP id f27mr31313291pff.89.1557718162057; Sun, 12 May 2019 20:29:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557718162; cv=none; d=google.com; s=arc-20160816; b=yRwklxNJeq+6XlC10xfwaySIJPjR/PCrAdAWdbV9tRuojakjLEar8bqSlst2oJ7wPN QNUGqnFTvjRavlDE5Yvhx6/xbNSoSnkNi6EpKaZgt92Z56si3qtursyfP47auCAcjuw0 a9eQz3hxNgWYuh7M5F2My1F+Y6bcgP84qspCnxNOJeeYI1/yCabkE0qxTmSyXN2nMjLe R1dyspH0Kxk9/5FOxAPugy0kGJTT1fM0H5EkJZHgo3oP+pCyupbTKZ1UDrBRnbERGW67 aiNuxCacqi+pIU9DOJ7Ixjla5WSGwlQIqv6z/kDy92HmVr1lHDlkBaR8cW2uoNDlxTQ7 5+Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wfoMnU1B5MwsGgUobBUJ9DN4Ws8VJ5pzaMDc3Fb2GBA=; b=VdQKknAN2jbg1w4vbxTrUs6EwdaIQAi7ayONyjDpW1b+XfbnBOi6b9UhXvj/XEb16/ 37akjP1I6NyE40yIzVmWE6a7SUUA6kQgNvXT/tcM8Ef4TwqRz5Sww3tGYACLrz6wUxFg BnHhWvDaTr4MnIHCmLK/JmqhjdqqJrKeqGs6JjU4F4OQVxslYvQa5uUP35b3Fdliuto5 ELt5559jP0LEpDjPt9mR+u0AOwNn6iC3HoRvR+FGW5euW8i4OqrxHI01DURILTl8sJA9 lF/3Wi5lFu+GJ4cAIDNWKbtFUoyiDja+rvR+oQsR5ZIa+z92uTUGMpwxov5otXYwMgts Taog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rrOw31zw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h68si15072687pgc.270.2019.05.12.20.29.05; Sun, 12 May 2019 20:29:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rrOw31zw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbfEMDYB (ORCPT + 99 others); Sun, 12 May 2019 23:24:01 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:40836 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727054AbfEMDYA (ORCPT ); Sun, 12 May 2019 23:24:00 -0400 Received: by mail-lj1-f195.google.com with SMTP id d15so9543979ljc.7 for ; Sun, 12 May 2019 20:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wfoMnU1B5MwsGgUobBUJ9DN4Ws8VJ5pzaMDc3Fb2GBA=; b=rrOw31zwjhDHCFNWNtO9LFKRbgxlbOMBNdz3cVZpOip1OQg7z+h7XtrwBpmuI0UVfW /jY37VLT58EpAaJLnQ1VlB7/rVFKbssVgPQ3SSM7zpCxkvyU9C5ACF7vbzTVp0VGADGL mXlRSPjzLrsLDxXR6eZtuKR/zNEMTZ/GElGkxAYXvR6xxIw/XHZBNGxWW0xpr+o4Y2tM TN3ePkz3q1ED3QkhG02k0IWHB/zuh/7cMqIxgoI8HZNlF47uZec9Yx1HkYgyw9/nm/Xy jmqsYGRRv8064lLLFeYHcMj+kS8AHuPqFLUouJQspeF3FgDFeq14L9f7vdPboW3LT2nI 9dHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wfoMnU1B5MwsGgUobBUJ9DN4Ws8VJ5pzaMDc3Fb2GBA=; b=B8XmLYj+v0lMyCO3u/HnJkvBHrkh0KZBtaPGXMW0oTFg/4CC1/HEOprmBDvGoDUH01 jgZRCdchp2YXf8yblQ/K/cg/z5XUpBw3craqA39tKc3lbnz5xCYYhcr1AoobR1/XwwW+ UdzThM3sEBlKOpuKFepR4Q4+z/kLC1/MgQvoY+HB3rH8M7YkeYSuQQswOsIFk9UeId/S xMvCu+3lBunRCsdekbS4ihcui3gXeuN1pKw/Q+m7IFW9gxrNWFg4/pMnp8YpJPnkGO+f CMpaOLr0FF3KLdGPk3gpijakBxwQDbQlKIaYdx8oAUk0CMD1RvH3qCTm02avz58g8YLi ldxg== X-Gm-Message-State: APjAAAWQr4UcC9pwLhDAMti/Zj3NrJy13ETA19Z+S334WD9HGJ/os4tM 8YoArhDGT+fwILX+RsBxIDTPRdIymxgxBtAzmw0= X-Received: by 2002:a2e:994:: with SMTP id 142mr4150099ljj.192.1557717838459; Sun, 12 May 2019 20:23:58 -0700 (PDT) MIME-Version: 1.0 References: <1557716049-22744-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1557716049-22744-1-git-send-email-Anson.Huang@nxp.com> From: Fabio Estevam Date: Mon, 13 May 2019 00:23:52 -0300 Message-ID: Subject: Re: [PATCH RESEND 1/2] soc: imx: Add SCU SoC info driver support To: Anson Huang Cc: "catalin.marinas@arm.com" , "will.deacon@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "maxime.ripard@bootlin.com" , "agross@kernel.org" , "olof@lixom.net" , "horms+renesas@verge.net.au" , "jagan@amarulasolutions.com" , "bjorn.andersson@linaro.org" , Leonard Crestez , "marc.w.gonzalez@free.fr" , "dinguyen@kernel.org" , "enric.balletbo@collabora.com" , Aisheng Dong , "robh@kernel.org" , Abel Vesa , "l.stach@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 12, 2019 at 11:59 PM Anson Huang wrote: > + soc_dev = soc_device_register(soc_dev_attr); > + if (IS_ERR(soc_dev)) { > + kfree(soc_dev_attr->revision); > + return -ENODEV; This should return PTR_ERR(soc_dev) instead.