Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4714034yba; Sun, 12 May 2019 20:41:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwann1aty+Cc7L/Hb7ikexZEUryg7K7TGvz39GjT1aQ/PEwawEYBjrWc9IQgx04Jr7XdhIv X-Received: by 2002:a63:3fc1:: with SMTP id m184mr28289451pga.222.1557718915720; Sun, 12 May 2019 20:41:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557718915; cv=none; d=google.com; s=arc-20160816; b=WkLO199Veb9LW3aRwjf6jdDMzo96/Mmoc6hojlqUiVpVQxQhieBgJjk4/RkSEPhWj1 pyMHIb3+GJUJGmH3dAhbp5dprkUN7MiavR7suj8p9NpkGPlOwUU5UFG3bS5fCGFHRF08 l+PEr6ELUUjqLD4oJMUol+Dak+JwWqh5yQa5qOq9IerzQX7hiJaaxD5iUEv20qbzRRrt nuDXJqTmJfTKcTiuCxyrJMqzDInEFrzW+9wOBbVvSQaI/Y9bgJW9dYQDU7/6+K9ZWSPN v+zi7Wsu+nQTJC1+PMOAyMI57UHD4Fh2XHhUli9pTTAdhHrAWhX640cksW5ixm0BO0J3 GjCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kFSE7bFFnbktj2ocg4ZHcDdWLHu2gnLS1nuSxzqjNPU=; b=HmKA8MusSse0fkfTfs+0RjX47vZpJ4FqQYoGBog+esCVHUooKqmPdi1ANjVPAm1d1/ Dp5ayPHjiL/64cgX+UxkV5qsYvgCarjRnKBG8/H+WpbzcsA9WGZIAT0gylBW0wY+8gMG HuIFfvIuO1XQ1460t426J6TAS5AEhsrQ5c9+J/XrlnXe8pu2/v6Kh8CAJIyml1F90jqh iZW9MbUauTi4SJ1GtNash0WiWZ6WvoEsb/eCyYGCc1wlGj5SVVW/kPW3k7UlhD7WNFo8 Sr58Pjf6NWINCGrhryWBoiXe5Hj/1Wu1b8msP8ul272YrlcVNO4WExaZpcvaXDrzZ/dr fW6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=zZvRWJQl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bh3si14281852plb.284.2019.05.12.20.41.39; Sun, 12 May 2019 20:41:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=zZvRWJQl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbfEMDk1 (ORCPT + 99 others); Sun, 12 May 2019 23:40:27 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:48009 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbfEMDk0 (ORCPT ); Sun, 12 May 2019 23:40:26 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6D874221AD; Sun, 12 May 2019 23:40:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 12 May 2019 23:40:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=kFSE7bFFnbktj2ocg4ZHcDdWLHu2gnLS1nuSxzqjNPU=; b=zZvRWJQl xkUdwF6tDIU9fbhNKHVNYUzGQS/tFwET14dixGRBziVNh3UO+JFXoISc6kFQifJh pZO8VKIs1ah4DGz6f8Ex05DwB+ubJFtHYZs9/5UTaFIYTv9ybRyEIyalvEeG6vSZ yFTXcOdjuLhSXyzkUb1LFv/0gDZKnuWSLUiVY4vGN0CVg35g6MMnwQ9xxTIX0Fca G6dbPBs9dGQTEfcKzXVjmDtRvBVxpKd7+vMMFmfH3JpEOe0pmT/JWweH6HppOLPI lGKu0PgZCeB1sJlCYzgXESXFEtOW0siJ5DaTY/G4f+XEaIX9LlkBn88KGaMYH/bm Y5/WcZJgQnJe+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleefgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepfdfvohgsihhn ucevrdcujfgrrhguihhnghdfuceothhosghinheskhgvrhhnvghlrdhorhhgqeenucfkph epuddvgedrudeiledrudeirddukeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehtohgs ihhnsehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from eros.localdomain (124-169-16-185.dyn.iinet.net.au [124.169.16.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 4822F8005A; Sun, 12 May 2019 23:40:22 -0400 (EDT) From: "Tobin C. Harding" To: Chris Mason , Josef Bacik , David Sterba Cc: "Tobin C. Harding" , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] fs: btrfs: Don't leak memory when failing add fsid Date: Mon, 13 May 2019 13:39:12 +1000 Message-Id: <20190513033912.3436-3-tobin@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190513033912.3436-1-tobin@kernel.org> References: <20190513033912.3436-1-tobin@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A failed call to kobject_init_and_add() must be followed by a call to kobject_put(). Currently in the error path when adding fs_devices we are missing this call. This could be fixed by calling btrfs_sysfs_remove_fsid() if btrfs_sysfs_add_fsid() returns an error or by adding a call to kobject_put() directly in btrfs_sysfs_add_fsid(). Here we choose the second option because it prevents the slightly unusual error path handling requirements of kobject from leaking out into btrfs functions. Add a call to kobject_put() in the error path of kobject_add_and_init(). This causes the release method to be called if kobject_init_and_add() fails. open_tree() is the function that calls btrfs_sysfs_add_fsid() and the error code in this function is already written with the assumption that the release method is called during the error path of open_tree() (as seen by the call to btrfs_sysfs_remove_fsid() under the fail_fsdev_sysfs label). Signed-off-by: Tobin C. Harding --- fs/btrfs/sysfs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 5a5930e3d32b..2f078b77fe14 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -825,7 +825,12 @@ int btrfs_sysfs_add_fsid(struct btrfs_fs_devices *fs_devs, fs_devs->fsid_kobj.kset = btrfs_kset; error = kobject_init_and_add(&fs_devs->fsid_kobj, &btrfs_ktype, parent, "%pU", fs_devs->fsid); - return error; + if (error) { + kobject_put(&fs_devs->fsid_kobj); + return error; + } + + return 0; } int btrfs_sysfs_add_mounted(struct btrfs_fs_info *fs_info) -- 2.21.0