Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4838239yba; Mon, 13 May 2019 00:03:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxSwoT9RfDMUHhJ3kiJxjtS0aHiKFPC0FoR68PkbAzEipkgdlzcsJzr9J1Hco0TM2kcwplV X-Received: by 2002:a63:1852:: with SMTP id 18mr29228755pgy.283.1557731038714; Mon, 13 May 2019 00:03:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557731038; cv=none; d=google.com; s=arc-20160816; b=X6nCCE53Vp4MHkbVqnBsZwBc1rtDwU/OT4JxIuZId4Y9nl5SEUtfKFQjCWCg6fCnG/ xXCrH6JozqL/5FUjjJ3kR5KHlHSarz3NqcQDqxsZsDND4pEpYeIKCnKhOUiIuQE+tUKU AGjDZZpiYZfimDdzL6jcG6PKyc0q6SCfsnGi7767nW+CHAO2SC2JUOjvq1YHZFvuKUjR stXgEf2ytUOIQ2vCT0sva8KURJKQ3o/vFZ5KTMVxxnbpV1+kuxiqFANTh/Ppq7wpnpuX tkwXBuj4PvnK/zOpQJzdgUnsk3eFsFGhraQ8xDReAfWlDFf6S8ZrzG+Q8oklihlEIIfJ AH4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=6sOnc3dpBI/BhPNxg5TySYeU/9kd68f0gBRmaaT1mWo=; b=B8hTU+jqkTlCZwbjcr6ghC5WxH1EaEDbnN/mx/Z8CzSQ6mwqWLBf5+b/rKeo5tFTsd SNS5dLtLs63CX1XusH9OjFB5+kDLW5jpw2xIAP+/k9f4ThqXOpp3AKgXDD5gQfW3OxkD bqb7PtA2Lx9G92vlzjnnqiSzdzpc2qF1aY0+zwNR5TLWiLwC+Nr1dAQbrAPHUlwrV1sT 1XQxVyImMuIqCQkhOuWAbyLBeuGxUfJyjI683wv/chmcYId9HTHxS3VJ/ZWF8Frlcxl0 R6BFPF5du4PdKlOuOZBe686R2JhkqIhrmdERQXXkmSaYz7e9cY55FskfWqtBhcq2P/yh NLoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r15si4047368pgi.16.2019.05.13.00.03.42; Mon, 13 May 2019 00:03:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbfEMGti (ORCPT + 99 others); Mon, 13 May 2019 02:49:38 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:49293 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfEMGti (ORCPT ); Mon, 13 May 2019 02:49:38 -0400 Received: from [192.168.178.187] ([109.104.40.7]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MD9Kp-1hYdLQ1ZJ3-00985K; Mon, 13 May 2019 08:49:17 +0200 Subject: Re: [PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret To: Colin King , Eric Anholt , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190511134813.5645-1-colin.king@canonical.com> From: Stefan Wahren Message-ID: <5fd5c89a-4bd0-1d2d-f027-819fe954bd5f@i2se.com> Date: Mon, 13 May 2019 08:49:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190511134813.5645-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:6gjO/x7pdDWHJchMfTFoYpMrc2jCJwMLYflU4Gu8ajN8J46umg6 aMe2yCTYt5dfh5L90OffWgr+De4ZEbH7zWOzULis8Wg7jHu11WCzgZWtKNKPAptARDx0oJ0 onjJagH2RY6NH+NAetYiMMsie9qoyv3MvH4KUKzjZocbDIdCRjsjk1SFU/5wxaBPr4iNuWQ hQtDghl6UxoBPf6cQUayg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ATE5Qe06IYI=:LutzhZvoFJqtjnVznCcyii tuxoWieuRi4pbG6k9Au0IJ9Ub5XgOXfj1MY0QsBkBbMXSbDvguUogyLLnjeSwNGOsWeOMjvSM 8AkIDckWw+Udpaq5coHqFCoxBKcqTR7tymRibv5jN5rdQTe4mOvO6FD6Cxvt5xk9taq/JjZJn jrCvrFs1sK6T9EdG8v0Adu8/TbKi8+UV9AvAIDXtJsnDHMeen1p5PYYLP3xRp86bo2osT0NzL gjEeHhxxREkPSAG3zyCYMeiMMgdOtvFpoiT6gStg5XSWBLCinF8NVQh91n/7yl/bddj2JjWGI 8fmMZFsL4MKtdLf4SBPlvPfx26E8QaGGPnL5CVeqqT8v7UsY2PpUyh05QtzsXlem2TNnGYdtH /b7eub9w1KSlYIAhLVUN41vJBSQGjgKWIgUav2Aim1M4Dw7uND/9bidkmVIKu3A3z4lY3OQoZ rDIu0sAWbt8ZzTOf3H2ERZPU0gDkDtxPV602BDNE2JIIIdO0+iThd7fQntiBQXFljbxxLj6ZY SdEZ1f6CfX5ji1ZM3gHrlI/hMwZXuB+NOPfSOzXYSAgLOPhbU2wXA6d5Vw+g5A4k+zvp79plc ZilfIzGQj5RS7eD1od8LSX00t9D0pz+yL1Ue+1Xvs/ALaEkzKRnnV/oo6RcUd4VeZ6MvUlMiD 1akkc4W8Sn/78m4OlWg088rvmNW8BJ9j+uUosZe0QQWCqFvYXJ9YTIICv0weU9AAR/pn8B25i R7N7C825vhSBDGmX7QLdXGT7S6Vx3XH2oT5Ig3b8K9XyfNS5TXKSbguR/3Y= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.05.19 15:48, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized however this is never read and later > it is being reassigned to a new value. The initialization is redundant and > hence can be removed. > > Addresses-Coverity: ("Unused Value") > Signed-off-by: Colin Ian King Acked-by: Stefan Wahren