Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4938568yba;
        Mon, 13 May 2019 02:24:41 -0700 (PDT)
X-Google-Smtp-Source: APXvYqyeGP7TbLLvrFmX5dBdIjso9pPJJ6+tQWavSUbPJSACAMjfneC4B7rFHbxN2S2CPppHJZ6b
X-Received: by 2002:a63:4147:: with SMTP id o68mr27367287pga.76.1557739481842;
        Mon, 13 May 2019 02:24:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1557739481; cv=none;
        d=google.com; s=arc-20160816;
        b=lSlEg7ZeOChWt89bvAe0keptgb92a5BK+KwRkjRiMiK0ftge2zzwivz3q/08Cbggar
         6xfL49udXbuDVZMinBcqtXWC8butTWQuHT3ds44+Skb1wRK8vpvJc5bbjhtr5JNj36uL
         dwVnvqPIxPPHj69CPymOHyueCSTnbLxnzMqyPRRXMymt8HuCAXXjbw8kYq/IytVrBdPO
         x9sIdHilEUH8cpmAza0aBTSHxDsdTuGn6toBPd/4+DXCV0lSprc6SWi/92Un0S/63cao
         Q1gxC4/zJaUIXK82TUX1fkbwvaz5couBqEVe9TxP7PtWRzCOOJBIcqpwSIwNVW9RIBcl
         gpkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=D7aIgNlT0F+HVdRt6Gb8NxUYyDC417V0FGKktPvgEM8=;
        b=SlOIK4gIlfDdi7kAqOGjr34oB2sHu+dFGL7EjeEr9nEaGaGrqGlpngvDqEHrLRGUQV
         sKerxfiiiMeSsKF+yKKDAZESlAYcx4+SYgJ6Zl2SadJqyEuyLFcz2NmZiO7VHAu/1w1e
         M2aehQ0a2O43SksgMtUkmRO4i9tE7NRVL7fv3XNfegK4j1P/JI13LbR08bqt8U/KJVX9
         rPwTVc+SNHn+1ZEtAPXWIjZ9Q2LOLkd6lVf9FjE1dIMMqosV1GYBtPA7wG294yJzGPZT
         s7db+yxsqVL1WFaQ0i5sWigtJ+s0lZDlzrLf7DnwteNAy4O+zc+nRmP8zMSil5eqt72x
         mDBg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id m10si15303977pgp.478.2019.05.13.02.24.24;
        Mon, 13 May 2019 02:24:41 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728475AbfEMJWT (ORCPT <rfc822;chauncqc@gmail.com> + 99 others);
        Mon, 13 May 2019 05:22:19 -0400
Received: from mail.us.es ([193.147.175.20]:35450 "EHLO mail.us.es"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728342AbfEMJWS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 May 2019 05:22:18 -0400
Received: from antivirus1-rhel7.int (unknown [192.168.2.11])
        by mail.us.es (Postfix) with ESMTP id 730EB1C4398
        for <linux-kernel@vger.kernel.org>; Mon, 13 May 2019 11:22:16 +0200 (CEST)
Received: from antivirus1-rhel7.int (localhost [127.0.0.1])
        by antivirus1-rhel7.int (Postfix) with ESMTP id 62B05DA791
        for <linux-kernel@vger.kernel.org>; Mon, 13 May 2019 11:22:16 +0200 (CEST)
Received: by antivirus1-rhel7.int (Postfix, from userid 99)
        id 57F93DA781; Mon, 13 May 2019 11:22:16 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int
X-Spam-Level: 
X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50,
        SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1
Received: from antivirus1-rhel7.int (localhost [127.0.0.1])
        by antivirus1-rhel7.int (Postfix) with ESMTP id 0D337DA709;
        Mon, 13 May 2019 11:22:12 +0200 (CEST)
Received: from 192.168.1.97 (192.168.1.97)
 by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int);
 Mon, 13 May 2019 11:22:12 +0200 (CEST)
X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int)
Received: from us.es (sys.soleta.eu [212.170.55.40])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        (Authenticated sender: 1984lsi)
        by entrada.int (Postfix) with ESMTPSA id D5D144265A32;
        Mon, 13 May 2019 11:22:11 +0200 (CEST)
Date:   Mon, 13 May 2019 11:22:11 +0200
X-SMTPAUTHUS: auth mail.us.es
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Jagdish Motwani <j.k.motwani@gmail.com>
Cc:     netdev@vger.kernel.org,
        Jagdish Motwani <jagdish.motwani@sophos.com>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        Florian Westphal <fw@strlen.de>,
        "David S. Miller" <davem@davemloft.net>,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] netfilter: nf_queue:fix reinject verdict handling
Message-ID: <20190513092211.isxyzpytenvocbx2@salvia>
References: <20190508183114.7507-1-j.k.motwani@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190508183114.7507-1-j.k.motwani@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Virus-Scanned: ClamAV using ClamSMTP
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jagdish,

On Thu, May 09, 2019 at 12:01:14AM +0530, Jagdish Motwani wrote:
> From: Jagdish Motwani <jagdish.motwani@sophos.com>
> 
> In case of more than 1 nf_queues, hooks between them are being executed
> more than once.

This refers to NF_REPEAT, correct?

I think this broke with 960632ece6949. If so, it would be good to add
the following tag to this patch then. It's useful for robots
collecting fixes for -stable kernels.

Fixes: 960632ece694 ("netfilter: convert hook list to an array")

> Signed-off-by: Jagdish Motwani <jagdish.motwani@sophos.com>

Thanks.