Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Viorel Suman <viorel.suman@nxp.com>
To:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Viorel Suman <viorel.suman@nxp.com>,
        "S.j. Wang" <shengjiu.wang@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Julia Lawall <Julia.Lawall@lip6.fr>,
        Colin Ian King <colin.king@canonical.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     dl-linux-imx <linux-imx@nxp.com>,
        Viorel Suman <viorel.suman@gmail.com>
Subject: [PATCH V2 2/2] ASoC: ak4458: add return value for ak4458_probe
Thread-Topic: [PATCH V2 2/2] ASoC: ak4458: add return value for ak4458_probe
Thread-Index: AQHVCXMCzF054fnn0U+h7l73qDbc+A==
Date:   Mon, 13 May 2019 10:02:44 +0000
Message-ID: <1557741724-6859-3-git-send-email-viorel.suman@nxp.com>
References: <1557741724-6859-1-git-send-email-viorel.suman@nxp.com>
In-Reply-To: <1557741724-6859-1-git-send-email-viorel.suman@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.7.4
x-originating-ip: [89.37.124.34]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 36a22c84-9c01-49df-a9d2-08d6d78a24bd
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VI1PR04MB4800;
x-ms-traffictypediagnostic: VI1PR04MB4800:
x-microsoft-antispam-prvs: <VI1PR04MB480041252B0CE940802B877A920F0@VI1PR04MB4800.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:883;
x-forefront-prvs: 0036736630
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(396003)(136003)(346002)(366004)(39860400002)(189003)(199004)(486006)(44832011)(446003)(66066001)(8936002)(8676002)(36756003)(4326008)(73956011)(66946007)(2501003)(86362001)(14454004)(478600001)(26005)(2201001)(102836004)(11346002)(476003)(2616005)(186003)(66446008)(64756008)(66556008)(66476007)(5660300002)(386003)(6506007)(305945005)(54906003)(7736002)(6116002)(316002)(110136005)(2906002)(99286004)(52116002)(25786009)(76176011)(6512007)(71200400001)(71190400001)(68736007)(81156014)(50226002)(81166006)(14444005)(256004)(53936002)(3846002)(6436002)(6486002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4800;H:VI1PR04MB4704.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: ea/HqAHvS8Vx+qgg9X04zTeVjgKMhnokOT1Xb74nLEz7ps400r81QWk1XIf5Are49cx9doUEAQIbdlXe6Enw2k0X4yFeI67DXHA3upYxtAsZWTAuc5TJHMJy5Ad9oMNgOVD1pp1StuJCxYTZGJJbRAn4qmS7O/lDBrFjVabsDX9ktDtoaSeAjGgqBeQ2E8lclpVFCGHBG+/Pc+AevgztwovOclxtyuN2i18BBbvBRYvtUHACu7TlqlisdMFN5GBGAXcupmYHwbC6T3ht6O7y7qVR9EnvFSanON3Tf7o7nRd61UYL3W6/S3mBpDKWHGxTtupiIvO6xQohpzd7Bp5hddqCTScm0+R3tL1UM6fKSOJaVLy2PmseglmAG/HOcbNpqloGI7QCFmedovEln3w7hLcAMM+bQHPOG4lengdnFi0=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <C61FD3D585FC4C449B7408E138CAF8C6@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36a22c84-9c01-49df-a9d2-08d6d78a24bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 10:02:44.3253
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

AK4458 is probed successfully even if AK4458 is not present - this
is caused by probe function returning no error on i2c access failure.
Return an error on probe if i2c access has failed.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
---
 sound/soc/codecs/ak4458.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
index baf990a..7156215 100644
--- a/sound/soc/codecs/ak4458.c
+++ b/sound/soc/codecs/ak4458.c
@@ -539,9 +539,10 @@ static void ak4458_power_on(struct ak4458_priv *ak4458=
)
 	}
 }
=20
-static void ak4458_init(struct snd_soc_component *component)
+static int ak4458_init(struct snd_soc_component *component)
 {
 	struct ak4458_priv *ak4458 =3D snd_soc_component_get_drvdata(component);
+	int ret;
=20
 	/* External Mute ON */
 	if (ak4458->mute_gpiod)
@@ -549,21 +550,21 @@ static void ak4458_init(struct snd_soc_component *com=
ponent)
=20
 	ak4458_power_on(ak4458);
=20
-	snd_soc_component_update_bits(component, AK4458_00_CONTROL1,
+	ret =3D snd_soc_component_update_bits(component, AK4458_00_CONTROL1,
 			    0x80, 0x80);   /* ACKS bit =3D 1; 10000000 */
+	if (ret < 0)
+		return ret;
=20
-	ak4458_rstn_control(component, 1);
+	return ak4458_rstn_control(component, 1);
 }
=20
 static int ak4458_probe(struct snd_soc_component *component)
 {
 	struct ak4458_priv *ak4458 =3D snd_soc_component_get_drvdata(component);
=20
-	ak4458_init(component);
-
 	ak4458->fs =3D 48000;
=20
-	return 0;
+	return ak4458_init(component);
 }
=20
 static void ak4458_remove(struct snd_soc_component *component)
--=20
2.7.4