Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4989315yba; Mon, 13 May 2019 03:29:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXqrQvmgWuCs+zcZnUwkbWuKFIIPAkpJ0oQigTnPQ6Jlw6VAo7UFjW2zezOQS/8EpvyHiI X-Received: by 2002:a17:902:ac1:: with SMTP id 59mr29498141plp.294.1557743379977; Mon, 13 May 2019 03:29:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557743379; cv=none; d=google.com; s=arc-20160816; b=0nF9FmWUBmu7wcf34dPiiVo2tanRU9P6REv/PzzqUDAeQinkcdTSd1X1DzKcp0TIfx bNhk6Pm/9hE5TSHj2hWVczP8+WqCX5Ru3OuwYLzbkKiXYGJg03NMzg4FNbJM7lJlf0ak EF5QuVbVkwam/9NDZ6lSOfEc/ehuGKzAuIxfrKBUGr0FYOactJXmmRmKXSc0sUZ27E3Z LGC7lagAlmH7yMVhhmso4scb6HDhgLC/SbrkIbHG1/ia1f0nusztTD9NNMS495MC4tK7 Z+LET+F8U94tCNw+qMKO+19W3+UN8vowYmvg6K/mnu9/4kSLWRTc3glellFRIGnGvme8 /BRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=bJxaXtld11J7EpJY/ubE9XnPEwBhl+14j873jhZ7f0U=; b=OZdlgxTnqi19EaPbfqQPsZuyxo/t3Xs70BrxryNeNUlE/LSFdIp2nGdqfqbG8IKJg1 /pFq/scAb+03J1JvGsbDeWmZqCKV51sqws1ll454dK9gVsSnPkkFfDwbnPeimOMAEx38 RspOpsUeq+eCp992V+dCZGdPts+BoER7nSYvXKd3758t6mGTsdjMDEx3rCLTtVcYrtw8 sJf021wklKzX/5df36TbPFmJHS1oXJDiVCP09sxsOvcQGqprRg/mcyF/EKnE98XgW5ne Hoyw6CQzw10rkRp90c1dH3D3Md/K7Gp39BbyFvmlFy21SV6pnjq4ApNyY94609fqyWcg O8XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b="GEI6Eav/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21si15687902pgb.560.2019.05.13.03.28.53; Mon, 13 May 2019 03:29:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b="GEI6Eav/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728722AbfEMKCo (ORCPT + 99 others); Mon, 13 May 2019 06:02:44 -0400 Received: from mail-eopbgr80083.outbound.protection.outlook.com ([40.107.8.83]:46246 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727937AbfEMKCo (ORCPT ); Mon, 13 May 2019 06:02:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJxaXtld11J7EpJY/ubE9XnPEwBhl+14j873jhZ7f0U=; b=GEI6Eav/rIKlRFhrZv4OTbQw7b8CL/TpFw1ZvONF14R/y+3Y0q7ObU5lZqUxpT1H7OgqMrVp1S3MOpGgh31T99VXslETvMLkpOofLlvNFq88DoLnQdz7pjSRfMWZVW6VvtPfoLDDNg17rg6Ruski2qhi1JbQiK1Ed9Dq27M91vM= Received: from VI1PR04MB4704.eurprd04.prod.outlook.com (20.177.48.157) by VI1PR04MB4800.eurprd04.prod.outlook.com (20.177.48.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.22; Mon, 13 May 2019 10:02:40 +0000 Received: from VI1PR04MB4704.eurprd04.prod.outlook.com ([fe80::18d6:6f21:db62:4fe7]) by VI1PR04MB4704.eurprd04.prod.outlook.com ([fe80::18d6:6f21:db62:4fe7%2]) with mapi id 15.20.1878.024; Mon, 13 May 2019 10:02:40 +0000 From: Viorel Suman To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Viorel Suman , "S.j. Wang" , Daniel Baluta , Julia Lawall , Colin Ian King , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" CC: dl-linux-imx , Viorel Suman Subject: [PATCH V2 0/2] ASoC: ak4458: fail on probe if codec is not present Thread-Topic: [PATCH V2 0/2] ASoC: ak4458: fail on probe if codec is not present Thread-Index: AQHVCXMAooMElnxpc0yse1llpX1Jpw== Date: Mon, 13 May 2019 10:02:40 +0000 Message-ID: <1557741724-6859-1-git-send-email-viorel.suman@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR08CA0227.eurprd08.prod.outlook.com (2603:10a6:802:15::36) To VI1PR04MB4704.eurprd04.prod.outlook.com (2603:10a6:803:52::29) authentication-results: spf=none (sender IP is ) smtp.mailfrom=viorel.suman@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [89.37.124.34] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d9992afa-b2b0-490f-f4c8-08d6d78a2283 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VI1PR04MB4800; x-ms-traffictypediagnostic: VI1PR04MB4800: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0036736630 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(396003)(136003)(346002)(366004)(39860400002)(189003)(199004)(486006)(44832011)(66066001)(8936002)(8676002)(36756003)(4326008)(73956011)(66946007)(2501003)(86362001)(14454004)(478600001)(26005)(2201001)(4744005)(102836004)(476003)(2616005)(186003)(66446008)(64756008)(66556008)(66476007)(5660300002)(386003)(6506007)(305945005)(54906003)(7736002)(6116002)(316002)(110136005)(2906002)(99286004)(52116002)(25786009)(6512007)(71200400001)(71190400001)(68736007)(81156014)(50226002)(81166006)(14444005)(256004)(53936002)(3846002)(6436002)(6486002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4800;H:VI1PR04MB4704.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: L2EY0GRJQwBLjEYX/0p+vGw7x8ITUBWy7TDi2q11aIhK2FXODPoxX1sAJAT5lyacBwpSPs2Yr1CD7Lwjby9lmgYsSvMI9UIXKlzBOcYhiivNKjqk7xKUMamC7FDCCrSAj+MEkquj1lE3X0VfKFAB+EAWyyLydEQFaCzVzyKPId8vJhzAeIHH/JZt845stRDuKwclFKBHcAJb3HVs3SclgW++AUrjdj/OhUZQXqcxIfNIcowNeA5+9iZ4qVLYunQkqvJgjStOwSqyGZNvNq5/qTLp5w8CQWrK/kjOb0YlcdtkPB3zkDiNIKzHPnGi1S9ISobi3iiCwXh1TMFwWqGQNnvAInltm0+A6rM8+aFPn8JeS3QAwxdYCvZDWE6S7/je0ET9gRW5OoAdvU4c5nC0wc+CUhELOH9Veihpn4+fU68= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <79CDC12B48637547BD62FEE56C6A0ACA@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9992afa-b2b0-490f-f4c8-08d6d78a2283 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 10:02:40.6017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org AK4458 is probed successfully even if AK4458 is not present - this is caused by probe function returning no error on i2c access failure. The patchset fixes this. Changes since V1: Conditional statement rewritten as suggested by Mark. Viorel Suman (2): ASoC: ak4458: rstn_control - return a non-zero on error only ASoC: ak4458: add return value for ak4458_probe sound/soc/codecs/ak4458.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) --=20 2.7.4