Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5038201yba; Mon, 13 May 2019 04:25:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqzA/pY32w5CrHIk/9/fwfoBsqiDzo8N+83lJWK+Z78DKjA5PVXhw9xsXcfMbsLGj2n50l+d X-Received: by 2002:a17:902:bd94:: with SMTP id q20mr7659930pls.146.1557746726316; Mon, 13 May 2019 04:25:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557746726; cv=none; d=google.com; s=arc-20160816; b=oL+Uh3d9aN06bQOSPQk3fE8tajpaeqkn7LZrSV5o4KGPyuyunR8aruodEXI7suNdcj HVltPUZVxktHDSiNiO5SP/bgOHOrbUPF5YPqWxbQgx8c0OtLINbguIqJSNCQGJnMDtz/ 5rMGmWp2lDTXEjhpJwAkkPQnueiAfMvUqyXNWAcq/XYXg6ETIQxkHlQtpDHivvdxaY+o mgrVlpwhZf3Hm2RRdOxjuei1RO2jDKNX/JowRBPTiO8RGF9QZlraMEC0MdGRehVaacJb LPEpHOF0TxsUS6Zq7hmolTm6gOvnys8OX4Vy2KM78yQ+kIUvSX+hp95sfPLMPtj5x+GS vFrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=bktjGLcSisOIK0AmfyP4MoaNPyvxSX0jOjjjPY/5R7A=; b=AhUmfjP1Ku7mZ/hTEdcq/N/CJcJPC+1mb5Si/Sdt6KCmC7fhNJBwG6WKrysDkeqmN0 75VCK8TgIzeTfySIDwccnVeieBCWJH8KCbSrUrvSGsWiCGc+EA7vdh5eBpP47pLLT/wf 1ow5XT/dgF2D0gWgZmuY4Y8AUdpplmcM6qEO28KNDKdN8IF15SvsgvIyoMr0Z9DV6+Ov FlXROtosAICWTj9zuuiI4jpq3iDdsCCQZ06I9xKpKnvHEVxlKGzRH9enijVWWo6H7qG7 3GQEcGuJ5fZrLEilUpR4ew6aolFq5LqpfXhUukFNtsOPjZdA4xXcrLYq9wxLyfXL40jF eS/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si2696335pfb.7.2019.05.13.04.25.09; Mon, 13 May 2019 04:25:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729073AbfEMKk4 (ORCPT + 99 others); Mon, 13 May 2019 06:40:56 -0400 Received: from mail.us.es ([193.147.175.20]:41430 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbfEMKk4 (ORCPT ); Mon, 13 May 2019 06:40:56 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 928CEE5A40 for ; Mon, 13 May 2019 12:40:54 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 76590DA737 for ; Mon, 13 May 2019 12:40:54 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 70129DA709; Mon, 13 May 2019 12:40:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7D7EDDA701; Mon, 13 May 2019 12:40:45 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 13 May 2019 12:40:35 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 228C8406740D; Mon, 13 May 2019 12:40:32 +0200 (CEST) Date: Mon, 13 May 2019 12:40:31 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jagdish Motwani Cc: Jagdish Motwani , "netdev@vger.kernel.org" , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net] netfilter: nf_queue:fix reinject verdict handling Message-ID: <20190513104031.np2ollc6njuof2s2@salvia> References: <20190508183114.7507-1-j.k.motwani@gmail.com> <20190513092211.isxyzpytenvocbx2@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 13, 2019 at 10:36:51AM +0000, Jagdish Motwani wrote: > Hi Pablo, > > The case I am referring to is : If there are more than 1 hooks > returning NF_QUEUE verdict. When the first queue reinjects the > packet, 'nf_reinject' starts traversing hooks with hook_index (i). > However if it again receives a NF_QUEUE verdict (by some other > netfilter hook), it queue with the wrong hook_index. So, when the > second queue reinjects the packet, it re-executes some hooks in > between the first 2 hooks. Please, include this description in the patch. And thanks for explaining. > Thanks, I will mark : Fixes: 960632ece694 ("netfilter: convert hook list to an array") and update the description also. Thanks, will wait for v2.