Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5039163yba; Mon, 13 May 2019 04:26:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxojzGj2p2v7fUzgZU1aTRJFAZcvedDujJa35hR7hyFvnYH2bRr546Sn6WX74W+er+nlnV X-Received: by 2002:a17:902:112b:: with SMTP id d40mr30093840pla.31.1557746793715; Mon, 13 May 2019 04:26:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557746793; cv=none; d=google.com; s=arc-20160816; b=cdn10WMZhQzY7ttvjJ0LDhs9hKWJqKXvC/qiJ7U3vc1Ki9BFiQ+gODakqC7kBiJGPp Gx2/fBoJe6RO1DaCFu4c5We8ZuxHF0lCQnZcvG9wZKBa9hSs2g/NvcghKDxNT2QCOZhZ Tq2hTEiajksGgNXGVaHwqaI+PUxiWnRhrprjYLWDUmhORXRWIJyfqMz/fTzCfaDHzkjC nRlBiT01bOSe8oI+B5tq/QGXy8OdtW7V82Gpqq/v6mucZIiN94QX74F9AuCciyTpSt5v qlUXAKZxkfxI27Jdk5ehZvJuh2Tw3VdiKYw2sQaWX/SztUTfy6I4U/hHlRdNApkoEISz fQMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=U49fQLHYOqmtPc0EpZSr4iexl3fi+WfNrduBT7mOqOI=; b=YDZVtFFsxofiV44TORkSqLDCrte3679YeB7npZuxRvBtSHCpiwoh82sEkToxoh03pr qCf8JfK+/MGU59YODsbfMEGT5d6dins6tn5QUDjMu50Rn8NAPXhu5JwSrC6kxG8V0G/T CnqtoQFGBq4T/pgj/5aJA+AGpm/vaqXVcA3L/y+LBdIYfPdq5brYnsqQRS64xT8XoybO FO+fu2knkodAP00JwdPZBEC2Ag97irUiqUZid36pip1cpgrT4yp9GF2rzi5xrELLA/nS DU5WP1oWEpWQy7now4fkti6GhTugptrvWsVNVls0eOToM5r51l8Pu40cuMe+/0gZ+EI8 jxxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=zVlr2NKE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c13si15695337plo.175.2019.05.13.04.26.17; Mon, 13 May 2019 04:26:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=zVlr2NKE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729089AbfEMKl2 (ORCPT + 99 others); Mon, 13 May 2019 06:41:28 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:55500 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727272AbfEMKl1 (ORCPT ); Mon, 13 May 2019 06:41:27 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4DAd2GA178407; Mon, 13 May 2019 10:41:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=U49fQLHYOqmtPc0EpZSr4iexl3fi+WfNrduBT7mOqOI=; b=zVlr2NKEhYmH0lMooq0qd62v5XtBJeFLF7QQFdzs36yt15UY+f3b+ofTCQv4ysKRIVMZ 6q4MuHFVOtSxU38lRr9bVfDqeUM/ubnaoTP7XVM/bY2ZaAItmtQgqsuxUCIrV0n0+zFX 3AtmRyZcx72XscOi8PAMVrA1Y1vFtqbSIqHJdHQSzzsYMb7TVtqs4L9kaetLyNytV5L9 iCBzR5MzcKemaPZG/sdU+uF7/6JgjEVt1GC314SY5aPckYncvXkklXkCgUDkKawkrpRb vzRM8c41OFBd554C9XGsCuDB2uODPugQLR+dkxQOx0e3zE84hZJvmOW4PmS+yqIFjgcz WA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2sdq1q5x64-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 May 2019 10:41:18 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4DAdbXn007284; Mon, 13 May 2019 10:41:18 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2sdnqhvsq4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 May 2019 10:41:18 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x4DAfFLV013898; Mon, 13 May 2019 10:41:15 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 May 2019 03:41:14 -0700 Date: Mon, 13 May 2019 13:41:05 +0300 From: Dan Carpenter To: Hariprasad Kelam Cc: Greg Kroah-Hartman , Michael Straube , Mamta Shukla , Emanuel Bennici , Wen Yang , Jia-Ju Bai , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, viswanath.barenkala@gmail.com Subject: Re: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret Message-ID: <20190513104104.GH18105@kadam> References: <20190512113245.GA2221@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190512113245.GA2221@hari-Inspiron-1545> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9255 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=615 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905130077 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9255 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=662 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905130077 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please "drivers" out of the subject line. We know it's drivers, so that doesn't add any information. The "staging: " bit tells you which git tree this path is in, and the "rtl8723bs: " tells you which driver it is. regards, dan carpenter