Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5057114yba;
        Mon, 13 May 2019 04:46:17 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzYFldp4I2RZl4+0BanZHrShWtHxmlrKtdyNNUrlr7fOXQ59PqLmILAULf9tU4R7lUYLXr/
X-Received: by 2002:a65:448b:: with SMTP id l11mr29827412pgq.185.1557747977215;
        Mon, 13 May 2019 04:46:17 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1557747977; cv=none;
        d=google.com; s=arc-20160816;
        b=PPNRqkdn3DR1mrv693ZtmQ378kbA6pm64z2kFLOjT4BNSRn1PCUIFVS78m2to9G+C+
         8Ts//CnttsFoi1vTqlo9ahprR/88hObOenF3kJrxx6utYzvK+/YCIg9MMl+v6cwcU94d
         DGkWguv5cCFlJxemHih9QjEKodqVxVBuaUYqgH31BO3k5RdE/KNi9tc4GOD61YzbcdXO
         iLJkawOo+pG9tR3eo1xsXKC2CTRNB5GjP1MMg5aMuYoD4/y+7ni9ONdL1D8R/DGkYnSg
         Yv8vMt9EzZXk53lIAwBO0nQQ/S7VJYm83WpAQtH/VPByzE9EJluAjM0lWIdhqI6waSUb
         EkVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:in-reply-to
         :mime-version:user-agent:date:message-id:organization:from
         :references:cc:to:subject;
        bh=FFTwFZyuzivZSxUxRIZSx3aGvMLYa8uvc8EX2Kvqhlc=;
        b=aJYxQrVLfvstAalyoU5v5DONrwexfClkeddLdQ9RXrlnu1ahKJRF2b2BROzv3R3NZC
         AW17F1o1dSNlg6hwOj6TVfMODu9vtQ6ZvuIJC5rOFWtCO6xGulIzJ6v0M5p4PoYXKZcg
         39RVYfFZG2sZmuv5/Ib6TYCgSnY2I4bIAzaGWPWU1X3mUzENB2EdJqNliYlAr/NFZ4XZ
         1Roxr0bqqFnpRMUaJybHFrsYMvrNbxtA8si2l29x75IPSLXZ/ZQQW8nNT7b08twAojiC
         qqkx4hpfWoG3Ee3pHlHbVtwl+1G/aLdLz8qgswRYOZmR+lWsSYCM2vnDAMeuFPIgh8q4
         IR7w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id m5si15988244pgt.73.2019.05.13.04.46.01;
        Mon, 13 May 2019 04:46:17 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728207AbfEMLU5 (ORCPT <rfc822;wxiaokuan@gmail.com> + 99 others);
        Mon, 13 May 2019 07:20:57 -0400
Received: from mutluit.com ([82.211.8.197]:36258 "EHLO mutluit.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726103AbfEMLU4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 May 2019 07:20:56 -0400
Received: from [127.0.0.1] (s2.mutluit.com [82.211.8.197]:51448)
        by mutluit.com (s2.mutluit.com [82.211.8.197]:50025) with ESMTP ([XMail 1.27 ESMTP Server])
        id <S16FAD52> for <linux-kernel@vger.kernel.org> from <um@mutluit.com>;
        Mon, 13 May 2019 07:20:52 -0400
Subject: Re: [RFC PATCH v2 RESEND] drivers: ata: ahci_sunxi: Increased
 SATA/AHCI DMA TX/RX FIFOs
To:     Maxime Ripard <maxime.ripard@bootlin.com>
Cc:     Jens Axboe <axboe@kernel.dk>, Chen-Yu Tsai <wens@csie.org>,
        linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
        linux-amarula@amarulasolutions.com,
        Jagan Teki <jagan@amarulasolutions.com>,
        Pablo Greco <pgreco@centosproject.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Oliver Schinagl <oliver@schinagl.nl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Hans de Goede <hdegoede@redhat.com>,
        FUKAUMI Naoki <naobsd@gmail.com>,
        Andre Przywara <andre.przywara@arm.com>,
        Stefan Monnier <monnier@iro.umontreal.ca>
References: <20190512205954.18435-1-um@mutluit.com>
 <20190513095916.yyjdtueeefkf4v4b@flea>
From:   "U.Mutlu" <um@mutluit.com>
Organization: mutluit.com
Message-ID: <5CD95314.4060307@mutluit.com>
Date:   Mon, 13 May 2019 13:20:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101
 Firefox/40.0 SeaMonkey/2.37a1
MIME-Version: 1.0
In-Reply-To: <20190513095916.yyjdtueeefkf4v4b@flea>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Maxime Ripard wrote on 05/13/2019 11:59 AM:
> On Sun, May 12, 2019 at 10:59:54PM +0200, Uenal Mutlu wrote:
>> Increasing the SATA/AHCI DMA TX/RX FIFOs (P0DMACR.TXTS and .RXTS, ie.
>> TX_TRANSACTION_SIZE and RX_TRANSACTION_SIZE) from default 0x0 each
>> to 0x3 each, gives a write performance boost of 120 MiB/s to 132 MiB/s
>> from lame 36 MiB/s to 45 MiB/s previously.
>> Read performance is about 200 MiB/s.
>> [tested on SSD using dd bs=2K/4K/8K/12K/16K/24K/32K: peak-perf at 12K].
>>
>> Tested on the Banana Pi R1 (aka Lamobo R1) and Banana Pi M1 SBCs
>> with Allwinner A20 32bit-SoCs (ARMv7-a / arm-linux-gnueabihf).
>> These devices are RaspberryPi-like small devices.
>>
>> This problem of slow SATA write-speed with these small devices lasts now
>> for more than 5 years. Many commentators throughout the years wrongly
>> assumed the slow write speed was a hardware limitation. This patch finally
>> solves the problem, which in fact was just a hard-to-fix software problem
>> (b/c of lack of documentation by the SoC-maker Allwinner Technology).
>>
>> RFC: Since more than about 25 similar SBC/SoC models do use the
>> ahci_sunxi driver, users are encouraged to test it on all the
>> affected boards and give feedback.
>>
>> Lists of the affected sunxi and other boards and SoCs with SATA using
>> the ahci_sunxi driver:
>>    $ grep -i -e "^&ahci" arch/arm/boot/dts/sun*dts
>>    and http://linux-sunxi.org/SATA#Devices_with_SATA_ports
>>    See also http://linux-sunxi.org/Category:Devices_with_SATA_port
>>
>> Patch v2:
>>    - Commented the patch in-place in ahci_sunxi.c
>>    - With bs=12K and no conv=... passed to dd, the write performance
>>      rises further to 132 MiB/s
>>    - Changed MB/s to MiB/s
>>    - Posted the story behind the patch:
>>      http://lkml.iu.edu/hypermail/linux/kernel/1905.1/03506.html
>>    - Posted a dd test script to find optimal bs, and some results:
>>      https://bit.ly/2YoOzEM
>>
>> Patch v1:
>>    - States bs=4K for dd and a write performance of 120 MiB/s
>>
>> Signed-off-by: Uenal Mutlu <um@mutluit.com>
>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Thx!

> Just a minor nitpick though, the part starting with RFC: and with the
> version changelog should be after the --- below so that it doesn't get
> applied as part of the commit log.

Ok, I'll do it better in the future.
Thx again.


> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com