Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jagdish Motwani <Jagdish.Motwani@Sophos.com>
To:     Pablo Neira Ayuso <pablo@netfilter.org>,
        Jagdish Motwani <j.k.motwani@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        Florian Westphal <fw@strlen.de>,
        "David S. Miller" <davem@davemloft.net>,
        "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>,
        "coreteam@netfilter.org" <coreteam@netfilter.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net] netfilter: nf_queue:fix reinject verdict handling
Thread-Topic: [PATCH net] netfilter: nf_queue:fix reinject verdict handling
Thread-Index: AQHVBcxgq4KNCrDWoUOMWqDhWMYmkaZozxeAgAARJ/A=
Date:   Mon, 13 May 2019 10:36:51 +0000
Message-ID: <CWXP265MB1464BCF96C61A8FD47619AE59E0F0@CWXP265MB1464.GBRP265.PROD.OUTLOOK.COM>
References: <20190508183114.7507-1-j.k.motwani@gmail.com>
 <20190513092211.isxyzpytenvocbx2@salvia>
In-Reply-To: <20190513092211.isxyzpytenvocbx2@salvia>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: Sophos.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a31426d-79aa-4dd0-6f4a-08d6d78ee911
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 10:36:51.4016
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 358a41ff-46d9-49d3-a297-370d894eae6a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB0775
X-OriginatorOrg: sophos.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sophos.com; h=from:to:cc:subject:date:message-id:references:in-reply-to:content-type:content-transfer-encoding:mime-version; s=global; bh=ayMU9qBzLBcWoaFXnWug/xjIsNgYb4uRwNcwU8qXbSE=; b=VPKigIOPZArOA4gGzdTxf8p9pXioL4Qr2u4Vk+Kx5IN5VNatabFmvBTCkqn6MGztD5Bnem+I1ed9kbymkS3zBEZGGnCtPV5luAN6cqqfyVwfde5dMS/c3QIyK+ugZcUh/rrqEiRp3VcVTSwpzf22taXZwEcFfOdWNeYhM+6WnPA=
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Pablo,

The case I am referring to is : If there are more than 1  hooks returning N=
F_QUEUE verdict.
When the first queue reinjects the packet, 'nf_reinject' starts traversing =
hooks with hook_index (i).
However if it again receives a NF_QUEUE verdict (by some other netfilter ho=
ok), it queue with the wrong hook_index.
So, when the second queue reinjects the packet, it re-executes some hooks i=
n between the first 2 hooks.

Thanks, I will mark :  Fixes: 960632ece694 ("netfilter: convert hook list t=
o an array") and update the description also.

Regards,
Jagdish
-----Original Message-----
From: Pablo Neira Ayuso <pablo@netfilter.org>
Sent: Monday, May 13, 2019 2:52 PM
To: Jagdish Motwani <j.k.motwani@gmail.com>
Cc: netdev@vger.kernel.org; Jagdish Motwani <Jagdish.Motwani@Sophos.com>; J=
ozsef Kadlecsik <kadlec@blackhole.kfki.hu>; Florian Westphal <fw@strlen.de>=
; David S. Miller <davem@davemloft.net>; netfilter-devel@vger.kernel.org; c=
oreteam@netfilter.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] netfilter: nf_queue:fix reinject verdict handling

Hi Jagdish,


On Thu, May 09, 2019 at 12:01:14AM +0530, Jagdish Motwani wrote:
> From: Jagdish Motwani <jagdish.motwani@sophos.com>
>
> In case of more than 1 nf_queues, hooks between them are being
> executed more than once.

This refers to NF_REPEAT, correct?

I think this broke with 960632ece6949. If so, it would be good to add the f=
ollowing tag to this patch then. It's useful for robots collecting fixes fo=
r -stable kernels.

Fixes: 960632ece694 ("netfilter: convert hook list to an array")

> Signed-off-by: Jagdish Motwani <jagdish.motwani@sophos.com>

Thanks.

________________________________

Sophos Technologies Private Limited Regd. Office: Sophos House, Saigulshan =
Complex, Beside White House, Panchvati Cross Road, Ahmedabad - 380006, Guja=
rat, India CIN: U72200GJ2006PTC047857

Sophos Ltd, a company registered in England and Wales number 2096520, The P=
entagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom.