Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5105580yba; Mon, 13 May 2019 05:33:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmLXZAQZGXL4Etqvzma3XelrMOTXHSzGzphNLQx2Ad5iEhwkrn4C6pyw06Ycqlk2vJ6883 X-Received: by 2002:a63:9d83:: with SMTP id i125mr25551572pgd.229.1557750829198; Mon, 13 May 2019 05:33:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557750829; cv=none; d=google.com; s=arc-20160816; b=YFAea1CmWy8SaTM0q2IYMciK8fiTycBNrM1dPH1p2GCoBdqbg5/ndubAfIc4th+Jmn a0eeQcxv2w6DNgXEgMn1+hqKhBzRnbaJ1fhMI6jvHf3CvcV3EjHHDZw+uEfOavJyLqnG ZL/Tp9PmV2EwENzfnA/9NJIwRKfWZ+eGgpTLR8xIanT8HEzt68zEUsHahqTNC1crkryi tytMJ3Hkd0FaiSz9GursN9w8in0gmrFpsqOeyvhSCUdOfup2rNJAhI0Gg1e6v3ro/2Cb 8H3qN5VwjwtYFZKKWWKglxO3ngHb+9clDuWNRaQfT76OMT13a+I3hxzll+738vSohd17 Ptkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tSqs9AMTThdU8qxkTIlNJvkPD11kfEkOfLcrJZGQml0=; b=JXQb/uCr/pmaRX4/ZoHpr1BhNtMwqP8kYUPYJjFw1cr8M8pEVT21AhmIK6V+iPj+Zs geCWRqBU9WyfVW3nCMp0qVff7wpupZwUXjAf/We+lFqxiZOO8SsQVmDWIcxUMehB+LT3 QxKvuleurQJajpVXdXdrVJcCDkh1gWlMpMNLRmWTyK4ufWCSbG9g1M4rszUDiSC9ueIw 96y4qeTblk7t7pCx3mPfnUeprRVqvwIbILcALTwPtpm198x6RVzgdVr5+C1/3UjUUSRM ptwn29xIzlduHWs+A4Vm8pqkUmcBnTdYrpgJD8Lr188AiqTMEUTjVa7f+7mEIe+R6yY/ qTdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=mKtDdwld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si16034986pgz.358.2019.05.13.05.33.33; Mon, 13 May 2019 05:33:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=mKtDdwld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728932AbfEMLaQ (ORCPT + 99 others); Mon, 13 May 2019 07:30:16 -0400 Received: from merlin.infradead.org ([205.233.59.134]:53710 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726866AbfEMLaQ (ORCPT ); Mon, 13 May 2019 07:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tSqs9AMTThdU8qxkTIlNJvkPD11kfEkOfLcrJZGQml0=; b=mKtDdwldcN/kKtSFZ0OV1rUjFo L0YIrcHbDGvnobIZdBJsGGRK/3OtPHsv+pwLV+N1crHBYJixbIy69FalNoT/p/4bcCN1cV5IHVsPx 1dNG/4Vk/9aCZc92b8CJgD+YNhgSRAcPNl3KZ/TLk9E74FIR2Az+lbD+LU+GGH7oobSmE/E+yuxCj 3pUqBNcyeOrlFbqTfaU5n1OAQ1KlarZ24EXN5aLfmwf9029FrgMZyw06lw2T8ATqOEKpW1Zl5e5dr XA37mg6cSNUgXrYFzhKxP6jHEXXxL378IkxE64xhKU9bPeNOsQZxvzCakjNE7FqeoqOM0Usnku0qB J1UbWAYw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQ99k-0006em-4j; Mon, 13 May 2019 11:30:08 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E04FD2029F87D; Mon, 13 May 2019 13:30:06 +0200 (CEST) Date: Mon, 13 May 2019 13:30:06 +0200 From: Peter Zijlstra To: Nadav Amit Cc: Yang Shi , "jstancek@redhat.com" , Andrew Morton , "stable@vger.kernel.org" , Linux-MM , LKML , "Aneesh Kumar K . V" , Nick Piggin , Minchan Kim , Mel Gorman , Will Deacon Subject: Re: [PATCH] mm: mmu_gather: remove __tlb_reset_range() for force flush Message-ID: <20190513113006.GP2623@hirez.programming.kicks-ass.net> References: <1557264889-109594-1-git-send-email-yang.shi@linux.alibaba.com> <20190509083726.GA2209@brain-police> <20190509103813.GP2589@hirez.programming.kicks-ass.net> <20190509182435.GA2623@hirez.programming.kicks-ass.net> <04668E51-FD87-4D53-A066-5A35ABC3A0D6@vmware.com> <20190509191120.GD2623@hirez.programming.kicks-ass.net> <7DA60772-3EE3-4882-B26F-2A900690DA15@vmware.com> <20190513083606.GL2623@hirez.programming.kicks-ass.net> <75FD46B2-2E0C-41F2-9308-AB68C8780E33@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75FD46B2-2E0C-41F2-9308-AB68C8780E33@vmware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 13, 2019 at 09:11:38AM +0000, Nadav Amit wrote: > BTW: sometimes you don’t see the effect of these full TLB flushes as much in > VMs. I encountered a strange phenomenon at the time - INVLPG for an > arbitrary page cause my Haswell machine flush the entire TLB, when the > INVLPG was issued inside a VM. It took me quite some time to analyze this > problem. Eventually Intel told me that’s part of what is called “page > fracturing” - if the host uses 4k pages in the EPT, they (usually) need to > flush the entire TLB for any INVLPG. That’s happens since they don’t know > the size of the flushed page. Cute... if only they'd given us an interface to tell them... :-)