Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5180355yba; Mon, 13 May 2019 06:45:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWWD6U7T1Whil86gUmKfyVh3abiUYzr2JOqJxum4cvZPyzTSsDkx2fwMQJyPxtuRV2vaa7 X-Received: by 2002:a17:902:6948:: with SMTP id k8mr31100891plt.81.1557755119908; Mon, 13 May 2019 06:45:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557755119; cv=none; d=google.com; s=arc-20160816; b=rCl0dV1LOWxklO8qFJjCxa2GixflCv7OxGM5NTr8skOuzbbJ5wIS4QJMWQlM3mmysp ElHlJP+igLDUPWX0KLHBWP/NhtNqRuGgkCZbZ0Qob/kyAzCSsdm2Q1KSqrS9duH+mcxv n1B4tb7AF9LEbkjMXlK52KtFdBSQpEYQNiiTmQblcwt/fiEud0IfH+ADucH73MKr3q60 IHgdGiYuH1voX+1VOSmFlV9Hu3E41HYOSQ4Tm+PT3HleAMsXr5t1MZyNYLaSEsLQYVSa /anAZM4u/rPNiP46Brn7um0kWCezi9+50jKzLTTxfmMwMDV/18mFvSvMl6X2o3XeONux bZGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date; bh=afAaJXP3Clx3ovXeKLp9KvoqV4a2Vyq14p/5kcmuQ94=; b=v8Bqojx8NdADxjDOny9iGShZb78QNT6774gTV/c8tnMe9voJJZnPXXso+zln1wAkhD yYI+bark2nQpqiAninS6nkroeowqOffM0BASV3eJkXULsRpRLFBWZQ9u3UzVaP3hrxXx +lBFc7yDWQtA6YuMf8gwwV8miXJKpwTf+cXiX09XmgmbxX8oVn5RBchBtqFZRnXJ6Aeg E0o8x1zN75AX46MimwmqmiZsI1tUkSWlyQm+Zdig3J+5lSBFlMj2SOhIfNltVsadafQ0 V8da6oc5zt0fpXBOU6O2p27VvWtPg1+2UXsJZpAoqSfveJarPoixUZQFxOq7B3Jov3OA lmlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 67si18127944pfe.269.2019.05.13.06.45.03; Mon, 13 May 2019 06:45:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728961AbfEMMmO (ORCPT + 99 others); Mon, 13 May 2019 08:42:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:36480 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728015AbfEMMmN (ORCPT ); Mon, 13 May 2019 08:42:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A67A9AF61; Mon, 13 May 2019 12:42:12 +0000 (UTC) Date: Mon, 13 May 2019 14:42:12 +0200 Message-ID: From: Takashi Iwai To: Amadeusz =?UTF-8?B?U8WCYXdpxYRza2k=?= Cc: , "Jaroslav Kysela" , Subject: Re: [PATCH v2] ALSA: hda: Fix race between creating and refreshing sysfs entries In-Reply-To: <20190513091801.985-1-amadeuszx.slawinski@linux.intel.com> References: <20190513091801.985-1-amadeuszx.slawinski@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 May 2019 11:18:01 +0200, Amadeusz Sławiński wrote: > > hda_widget_sysfs_reinit() can free underlying codec->widgets structure > on which widget_tree_create() operates. Add locking to prevent such > issues from happening. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110382 > Signed-off-by: Amadeusz Sławiński > --- > > Changes since v1: > - Moved mutexes around the callers > - Added comments noting that functions should be called with mutex held Applied, thanks. Takashi