Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 4/7] sched: Add pelt_rq tracepoint
To:     Qais Yousef <qais.yousef@arm.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org,
        Pavankumar Kondeti <pkondeti@codeaurora.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
        Quentin Perret <quentin.perret@arm.com>
References: <20190510113013.1193-1-qais.yousef@arm.com>
 <20190510113013.1193-5-qais.yousef@arm.com>
 <20190513121445.GT2623@hirez.programming.kicks-ass.net>
 <20190513124829.aybnwdh74bsm7ugv@e107158-lin.cambridge.arm.com>
From:   Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <da915e4d-07ce-2914-e090-0f8e3e9e9650@arm.com>
Date:   Mon, 13 May 2019 15:37:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190513124829.aybnwdh74bsm7ugv@e107158-lin.cambridge.arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/13/19 2:48 PM, Qais Yousef wrote:
> On 05/13/19 14:14, Peter Zijlstra wrote:
>> On Fri, May 10, 2019 at 12:30:10PM +0100, Qais Yousef wrote:
>>
>>> +DECLARE_TRACE(pelt_rq,
>>> +	TP_PROTO(int cpu, const char *path, struct sched_avg *avg),
>>> +	TP_ARGS(cpu, path, avg));
>>> +
>>
>>> +static __always_inline void sched_trace_pelt_cfs_rq(struct cfs_rq *cfs_rq)
>>> +{
>>> +	if (trace_pelt_rq_enabled()) {
>>> +		int cpu = cpu_of(rq_of(cfs_rq));
>>> +		char path[SCHED_TP_PATH_LEN];
>>> +
>>> +		cfs_rq_tg_path(cfs_rq, path, SCHED_TP_PATH_LEN);
>>> +		trace_pelt_rq(cpu, path, &cfs_rq->avg);
>>> +	}
>>> +}
>>> +
>>> +static __always_inline void sched_trace_pelt_rt_rq(struct rq *rq)
>>> +{
>>> +	if (trace_pelt_rq_enabled()) {
>>> +		int cpu = cpu_of(rq);
>>> +
>>> +		trace_pelt_rq(cpu, NULL, &rq->avg_rt);
>>> +	}
>>> +}
>>> +
>>> +static __always_inline void sched_trace_pelt_dl_rq(struct rq *rq)
>>> +{
>>> +	if (trace_pelt_rq_enabled()) {
>>> +		int cpu = cpu_of(rq);
>>> +
>>> +		trace_pelt_rq(cpu, NULL, &rq->avg_dl);
>>> +	}
>>> +}
>>
>> Since it is only the one real tracepoint, how do we know which avg is
>> which?
> 
> Good question. I missed that to be honest since we are mainly interested in cfs
> and I was focused into not adding too many tracepoints..
> 
> I'm happy to create a tracepoint per class assuming that's what you're
> suggesting.

IMHO, you should also consider irq (rq->avg_irq), so when people are 
tracing asystem with 'IRQ' or 'paravirtual steal' time accounting, they 
will get the full picture.