Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 May 2019 17:06:19 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Qais Yousef <qais.yousef@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org,
        Pavankumar Kondeti <pkondeti@codeaurora.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Quentin Perret <quentin.perret@arm.com>
Subject: Re: [PATCH v2 0/7] Add new tracepoints required for EAS testing
Message-ID: <20190513150619.GX2589@hirez.programming.kicks-ass.net>
References: <20190510113013.1193-1-qais.yousef@arm.com>
 <20190513122857.GU2623@hirez.programming.kicks-ass.net>
 <20190513134203.xmw6rsjwpj5b4tj6@e107158-lin.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190513134203.xmw6rsjwpj5b4tj6@e107158-lin.cambridge.arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 13, 2019 at 02:42:03PM +0100, Qais Yousef wrote:
> On 05/13/19 14:28, Peter Zijlstra wrote:
> > 
> > 
> > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> > index c8c7c7efb487..11555f95a88e 100644
> > --- a/include/trace/events/sched.h
> > +++ b/include/trace/events/sched.h
> > @@ -594,6 +594,23 @@ TRACE_EVENT(sched_wake_idle_without_ipi,
> >  
> >  	TP_printk("cpu=%d", __entry->cpu)
> >  );
> > +
> > +/*
> > + * Following tracepoints are not exported in tracefs and provide hooking
> > + * mechanisms only for testing and debugging purposes.
> > + */
> > +DECLARE_TRACE(pelt_cfs_rq,
> > +	TP_PROTO(struct cfs_rq *cfs_rq),
> > +	TP_ARGS(cfs_rq));
> > +
> > +DECLARE_TRACE(pelt_se,
> > +	TP_PROTO(struct sched_entity *se),
> > +	TP_ARGS(se));
> > +
> > +DECLARE_TRACE(sched_overutilized,
> > +	TP_PROTO(int overutilized),
> > +	TP_ARGS(overutilized));
> > +
> 
> If I decoded this patch correctly, what you're saying:
> 
> 	1. Move struct cfs_rq to the exported sched.h header

No, don't expose the structure, we want to keep that private. You can
use unqualified pointers.

> 	2. Get rid of the fatty wrapper functions and export any necessary
> 	   helper functions.

Right, that should get them read-only access to the members of those
structures and avoids the tracing code itself from becoming ugleh and
also avoids us having to export those structures (which we really don't
want to do).

> 	3. No need for RT and DL pelt tracking at the moment.

Nah, you probably want rt,dl,irq (as Dietmar pointed out), it's just
that your patched didn't do it right and I was lazy.

> I'm okay with this. The RT and DL might need to be revisited later but we don't
> have immediate need for them now.
> 
> I'll add to this passing rd->span to sched_overutilizied.

Or pass the rd itself and add another wrapper to extract the span.