Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Akinobu Mita <akinobu.mita@gmail.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
        Kenneth Heitke <kenneth.heitke@intel.com>,
        Keith Busch <keith.busch@intel.com>,
        Minwoo Im <minwoo.im.dev@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 1/7] devcoredump: use memory_read_from_buffer
Thread-Topic: [PATCH v3 1/7] devcoredump: use memory_read_from_buffer
Thread-Index: AQHVCNsOeO2apvtWyEKVBVay0Hpz5w==
Date:   Mon, 13 May 2019 15:28:28 +0000
Message-ID: <SN6PR04MB452758CB8027D6069A748E63860F0@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <1557676457-4195-1-git-send-email-akinobu.mita@gmail.com>
 <1557676457-4195-2-git-send-email-akinobu.mita@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a7732161-b6b6-4ce9-6ba4-08d6d7b7a5f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 15:28:28.1166
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4944
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>.=0A=
=0A=
On 05/12/2019 08:55 AM, Akinobu Mita wrote:=0A=
> Use memory_read_from_buffer() to simplify devcd_readv().=0A=
>=0A=
> Cc: Johannes Berg <johannes@sipsolutions.net>=0A=
> Cc: Keith Busch <keith.busch@intel.com>=0A=
> Cc: Jens Axboe <axboe@fb.com>=0A=
> Cc: Christoph Hellwig <hch@lst.de>=0A=
> Cc: Sagi Grimberg <sagi@grimberg.me>=0A=
> Cc: Minwoo Im <minwoo.im.dev@gmail.com>=0A=
> Cc: Kenneth Heitke <kenneth.heitke@intel.com>=0A=
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>=0A=
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>=0A=
> ---=0A=
> * v3=0A=
> - No change since v2=0A=
>=0A=
>   drivers/base/devcoredump.c | 11 +----------=0A=
>   1 file changed, 1 insertion(+), 10 deletions(-)=0A=
>=0A=
> diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c=0A=
> index f1a3353..3c960a6 100644=0A=
> --- a/drivers/base/devcoredump.c=0A=
> +++ b/drivers/base/devcoredump.c=0A=
> @@ -164,16 +164,7 @@ static struct class devcd_class =3D {=0A=
>   static ssize_t devcd_readv(char *buffer, loff_t offset, size_t count,=
=0A=
>   			   void *data, size_t datalen)=0A=
>   {=0A=
> -	if (offset > datalen)=0A=
> -		return -EINVAL;=0A=
> -=0A=
> -	if (offset + count > datalen)=0A=
> -		count =3D datalen - offset;=0A=
> -=0A=
> -	if (count)=0A=
> -		memcpy(buffer, ((u8 *)data) + offset, count);=0A=
> -=0A=
> -	return count;=0A=
> +	return memory_read_from_buffer(buffer, count, &offset, data, datalen);=
=0A=
>   }=0A=
>=0A=
>   static void devcd_freev(void *data)=0A=
>=0A=
=0A=