Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] modules: fix livelock in add_unformed_module()
To:     Prarit Bhargava <prarit@redhat.com>, Jessica Yu <jeyu@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        David Arcari <darcari@redhat.com>
References: <be47ac01-a5ac-7be1-d387-5c841007b45f@google.com>
 <20190510184204.225451-1-brho@google.com>
 <dd48a3a4-9046-3917-55ba-d9eb391052b3@redhat.com>
From:   Barret Rhoden <brho@google.com>
Message-ID: <d968a588-c43b-cfe1-6358-6c5d99f916a3@google.com>
Date:   Mon, 13 May 2019 10:37:03 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <dd48a3a4-9046-3917-55ba-d9eb391052b3@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi -

On 5/13/19 7:23 AM, Prarit Bhargava wrote:
[snip]
> A module is loaded once for each cpu.

Does one CPU succeed in loading the module, and the others fail with EEXIST?

> My follow-up patch changes from wait_event_interruptible() to
> wait_event_interruptible_timeout() so the CPUs are no longer sleeping and can
> make progress on other tasks, which changes the return values from
> wait_event_interruptible().
> 
> https://marc.info/?l=linux-kernel&m=155724085927589&w=2
> 
> I believe this also takes your concern into account?

That patch might work for me, but I think it papers over the bug where 
the check on old->state that you make before sleeping (was COMING || 
UNFORMED, now !LIVE) doesn't match the check to wake up in 
finished_loading().

The reason the issue might not show up in practice is that your patch 
basically polls, so the condition checks in finished_loading() are only 
a quicker exit.

If you squash my patch into yours, I think it will cover that case. 
Though if polling is the right answer here, it also raises the question 
of whether or not we even need finished_loading().

Barret