Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     "minwoo.im@samsung.com" <minwoo.im@samsung.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Keith Busch <keith.busch@intel.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Kenneth Heitke <kenneth.heitke@intel.com>,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Jens Axboe <axboe@fb.com>, Minwoo Im <minwoo.im.dev@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure
Thread-Topic: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure
Thread-Index: AQHVCNsnTq1EcjR34keOomYpqyVeRw==
Date:   Mon, 13 May 2019 15:23:32 +0000
Message-ID: <SN6PR04MB4527DFC75838C3236F5D05B2860F0@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <1557676457-4195-6-git-send-email-akinobu.mita@gmail.com>
 <1557676457-4195-1-git-send-email-akinobu.mita@gmail.com>
 <CGME20190512155540epcas4p14c15eb86b08dcd281e9a93a4fc190800@epcms2p1>
 <20190513074601epcms2p12c0a32730a16be3b69b68e3c9d4d0b92@epcms2p1>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c22052b7-3352-4936-2d36-08d6d7b6f5c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 15:23:32.5348
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4944
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/13/2019 12:46 AM, Minwoo Im wrote:=0A=
>> +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *=
buf,=0A=
>> +					 size_t bytes, loff_t offset)=0A=
>> +{=0A=
>> +	loff_t pos =3D 0;=0A=
>> +	u32 chunk_size;=0A=
>> +=0A=
>> +	if (check_mul_overflow(ctrl->max_hw_sectors, 512u, &chunk_size))=0A=
>> +		chunk_size =3D UINT_MAX;=0A=
>> +=0A=
>> +	while (pos < bytes) {=0A=
>> +		size_t size =3D min_t(size_t, bytes - pos, chunk_size);=0A=
>> +		int ret;=0A=
>> +=0A=
>> +		ret =3D nvme_get_log(ctrl, NVME_NSID_ALL,=0A=
>> NVME_LOG_TELEMETRY_CTRL,=0A=
>> +				   0, buf + pos, size, offset + pos);=0A=
>> +		if (ret)=0A=
>> +			return ret;=0A=
>> +=0A=
>> +		pos +=3D size;=0A=
>> +	}=0A=
>> +=0A=
>> +	return 0;=0A=
>> +}=0A=
>> +=0A=
>> +static int nvme_get_telemetry_log(struct nvme_ctrl *ctrl,=0A=
>> +				  struct sg_table *table, size_t bytes)=0A=
>> +{=0A=
>> +	int n =3D sg_nents(table->sgl);=0A=
>> +	struct scatterlist *sg;=0A=
>> +	size_t offset =3D 0;=0A=
>> +	int i;=0A=
>> +=0A=
A little comment would be nice if you are using sg operations.=0A=
>> +	for_each_sg(table->sgl, sg, n, i) {=0A=
>> +		struct page *page =3D sg_page(sg);=0A=
>> +		size_t size =3D min_t(int, bytes - offset, sg->length);=0A=
>> +		int ret;=0A=
>> +=0A=
>> +		ret =3D nvme_get_telemetry_log_blocks(ctrl,=0A=
>> page_address(page),=0A=
>> +						    size, offset);=0A=
>> +		if (ret)=0A=
>> +			return ret;=0A=
>> +=0A=
>> +		offset +=3D size;=0A=
>> +	}=0A=
>> +=0A=
>> +	return 0;=0A=
>> +}=0A=
>=0A=
> Can we have those two in nvme-core module instead of being in pci module?=
=0A=
=0A=
Since they are based on the controller they should be moved next to =0A=
nvme_get_log() in the ${KERN_DIR}/drivers/nvme/host/core.c.=0A=
=0A=
>=0A=
> _______________________________________________=0A=
> Linux-nvme mailing list=0A=
> Linux-nvme@lists.infradead.org=0A=
> http://lists.infradead.org/mailman/listinfo/linux-nvme=0A=
>=0A=
=0A=